Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2544283003: Use upcoming CTFont hb_face constructor (Closed)

Created:
4 years ago by ebrahimgnu
Modified:
3 years, 11 months ago
Reviewers:
drott, eae
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use upcoming CTFont hb_face constructor (just uploaded to test my unmerged change on harfbuzz to see if it fits with Chromium tests as I don't have local Mac build)

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Use upcoming CTFont hb_face constructor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -66 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontPlatformData.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-coretext.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-coretext.cc View 14 chunks +88 lines, -60 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
ebrahimgnu
eae, would you please run CI on this? This also helps memory consumption so I ...
4 years ago (2016-12-02 14:58:53 UTC) #2
eae
Triggered try bots, don't think we have any mac memory bots that work without landing.
4 years ago (2016-12-02 15:05:20 UTC) #5
ebrahimgnu
Tests results looks good but needs a rerun as some unrelated fails I rebased this.
4 years ago (2016-12-02 17:02:03 UTC) #8
eae
4 years ago (2016-12-07 21:32:25 UTC) #12
On 2016/12/02 17:02:03, ebrahimgnu wrote:
> Tests results looks good but needs a rerun as some unrelated fails I rebased
> this.

Triggered another run, sorry about the delay.

Powered by Google App Engine
This is Rietveld 408576698