Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 254423004: Web Animations API: Element.animate should accept a null effect (Closed)

Created:
6 years, 8 months ago by dstockwell
Modified:
6 years, 7 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, Inactive, darktears, arv+blink, Steve Block, dino_apple.com, watchdog-blink-watchlist_google.com, Eric Willigers
Visibility:
Public.

Description

Web Animations API: Element.animate should accept a null effect Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172834

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -6 lines) Patch
A LayoutTests/web-animations-api/element-animate-null-effect.html View 1 chunk +11 lines, -0 lines 0 comments Download
A + Source/core/animation/AnimationEffect.idl View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/ElementAnimation.h View 1 chunk +15 lines, -3 lines 0 comments Download
M Source/core/animation/ElementAnimation.idl View 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/core.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dstockwell
6 years, 8 months ago (2014-04-24 03:16:46 UTC) #1
alancutter (OOO until 2018)
lgtm https://codereview.chromium.org/254423004/diff/20001/LayoutTests/web-animations-api/element-animate-null-effect.html File LayoutTests/web-animations-api/element-animate-null-effect.html (right): https://codereview.chromium.org/254423004/diff/20001/LayoutTests/web-animations-api/element-animate-null-effect.html#newcode9 LayoutTests/web-animations-api/element-animate-null-effect.html:9: assert_true(element.animate(null, {duration: 1}) != null); assert_not_equals?
6 years, 8 months ago (2014-04-24 03:49:55 UTC) #2
alancutter (OOO until 2018)
https://codereview.chromium.org/254423004/diff/20001/Source/core/animation/ElementAnimation.h File Source/core/animation/ElementAnimation.h (right): https://codereview.chromium.org/254423004/diff/20001/Source/core/animation/ElementAnimation.h#newcode66 Source/core/animation/ElementAnimation.h:66: return 0; nullptr here and below.
6 years, 8 months ago (2014-04-24 03:53:08 UTC) #3
dstockwell
https://codereview.chromium.org/254423004/diff/20001/Source/core/animation/ElementAnimation.h File Source/core/animation/ElementAnimation.h (right): https://codereview.chromium.org/254423004/diff/20001/Source/core/animation/ElementAnimation.h#newcode66 Source/core/animation/ElementAnimation.h:66: return 0; On 2014/04/24 03:53:08, alancutter wrote: > nullptr ...
6 years, 8 months ago (2014-04-24 03:56:01 UTC) #4
alancutter (OOO until 2018)
https://codereview.chromium.org/254423004/diff/20001/Source/core/animation/ElementAnimation.h File Source/core/animation/ElementAnimation.h (right): https://codereview.chromium.org/254423004/diff/20001/Source/core/animation/ElementAnimation.h#newcode66 Source/core/animation/ElementAnimation.h:66: return 0; On 2014/04/24 03:56:01, dstockwell wrote: > On ...
6 years, 8 months ago (2014-04-24 04:00:40 UTC) #5
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 7 months ago (2014-04-29 00:39:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/254423004/40001
6 years, 7 months ago (2014-04-29 00:39:37 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 03:44:27 UTC) #8
Message was sent while issue was closed. 
Change committed as 172834

Powered by Google App Engine
This is Rietveld 408576698