Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2544163003: Simplify handler initialization for InputConnectionFactory (Closed)

Created:
4 years ago by Changwan Ryu
Modified:
4 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify handler initialization for InputConnectionFactory As a follow-up to https://codereview.chromium.org/2543893002/, we make the code easy to read and remove unnecessary findbug suppression. BUG=668692 Committed: https://crrev.com/4df6fe2be559a7b87411d369c401efd62ed01353 Cr-Commit-Position: refs/heads/master@{#436218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -31 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java View 8 chunks +18 lines, -24 lines 0 comments Download
M content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionFactoryTest.java View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Changwan Ryu
4 years ago (2016-12-02 09:05:52 UTC) #4
Torne
LGTM, thanks for doing this followup!
4 years ago (2016-12-02 12:14:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544163003/1
4 years ago (2016-12-05 01:17:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 02:02:28 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-05 02:03:54 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4df6fe2be559a7b87411d369c401efd62ed01353
Cr-Commit-Position: refs/heads/master@{#436218}

Powered by Google App Engine
This is Rietveld 408576698