Clean up --print-scopes output

Clean up --print-scopes output

Several cleanups to the output of the debug-only --print-scopes flag:
  - Function name variable only printed once
  - Only print headers for sections of variables that are non-empty
  - Assume Variables stored in Scope::variables_ are never null

R=verwaest@chromium.org

Committed: https://crrev.com/00b9c9e63b183e632edc43071d1e22a30a3b06fd
Cr-Commit-Position: refs/heads/master@{#41463}

[adamk, 2016-12-02 21:23:36]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 21:23:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-12-02 22:06:10]

ishell@chromium.org changed reviewers:
+ ishell@chromium.org

[Igor Sheludko, 2016-12-02 22:06:10]

lgtm with nits:

https://codereview.chromium.org/2544063004/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2544063004/diff/1/src/ast/scopes.cc#newcode1399
src/ast/scopes.cc:1399: static void PrintVar(int indent, Variable* var) {
While you are here please put this function into an anonymous namespace and
remove "static".

https://codereview.chromium.org/2544063004/diff/1/src/ast/scopes.cc#newcode1421
src/ast/scopes.cc:1421: static void PrintMap(int indent, const char* label,
VariableMap* map,
Same here.

[commit-bot: I haz the power, 2016-12-02 22:53:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 22:53:23]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-12-03 00:04:23]

https://codereview.chromium.org/2544063004/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2544063004/diff/1/src/ast/scopes.cc#newcode1399
src/ast/scopes.cc:1399: static void PrintVar(int indent, Variable* var) {
On 2016/12/02 22:06:10, Igor Sheludko wrote:
> While you are here please put this function into an anonymous namespace and
> remove "static".

Wrapped all these helpers in an anonymous namespace and removed the uses of
"static".

https://codereview.chromium.org/2544063004/diff/1/src/ast/scopes.cc#newcode1421
src/ast/scopes.cc:1421: static void PrintMap(int indent, const char* label,
VariableMap* map,
On 2016/12/02 22:06:10, Igor Sheludko wrote:
> Same here.

Done.

[adamk, 2016-12-03 00:04:39]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-12-03 00:04:39]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2544063004/#ps20001
(title: "Anonymous namespace")

[commit-bot: I haz the power, 2016-12-03 00:04:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 00:31:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480723479529700,
"parent_rev": "885ec8c1f1bf883ffaaec90e8cb1bfaf6e34cd33", "commit_rev":
"2be78e584652f5fae7256b891e036cc116eed50c"}

[commit-bot: I haz the power, 2016-12-03 00:31:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-03 00:31:55]

Description was changed from

==========
Clean up --print-scopes output

Several cleanups to the output of the debug-only --print-scopes flag:
  - Function name variable only printed once
  - Only print headers for sections of variables that are non-empty
  - Assume Variables stored in Scope::variables_ are never null

R=verwaest@chromium.org
==========

to

==========
Clean up --print-scopes output

Several cleanups to the output of the debug-only --print-scopes flag:
  - Function name variable only printed once
  - Only print headers for sections of variables that are non-empty
  - Assume Variables stored in Scope::variables_ are never null

R=verwaest@chromium.org

Committed: https://crrev.com/00b9c9e63b183e632edc43071d1e22a30a3b06fd
Cr-Commit-Position: refs/heads/master@{#41463}
==========

[commit-bot: I haz the power, 2016-12-03 00:31:55]

Patchset 2 (id:??) landed as
https://crrev.com/00b9c9e63b183e632edc43071d1e22a30a3b06fd
Cr-Commit-Position: refs/heads/master@{#41463}