Clean up --print-scopes output

src/ast/scopes.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/ast/scopes.h"
 
 #include <set>
 
 #include "src/accessors.h"
 #include "src/ast/ast.h"
@@ skipping 1378 matching lines @@
     case VariableLocation::LOOKUP:
       PrintF("lookup");
       break;
     case VariableLocation::MODULE:
       PrintF("module");
       break;
   }
 }
 
 
 static void PrintVar(int indent, Variable* var) {

[Igor Sheludko, 2016/12/02 22:06:10]

While you are here please put this function into an anonymous namespace and
remove "static".

[adamk, 2016/12/03 00:04:23]

Wrapped all these helpers in an anonymous namespace and removed the uses of
"static".

-  if (var->is_used() || !var->IsUnallocated()) {
-    Indent(indent, VariableMode2String(var->mode()));
-    PrintF(" ");
-    if (var->raw_name()->IsEmpty())
-      PrintF(".%p", reinterpret_cast<void*>(var));
-    else
-      PrintName(var->raw_name());
-    PrintF(";  // ");
-    PrintLocation(var);
-    bool comma = !var->IsUnallocated();
-    if (var->has_forced_context_allocation()) {
-      if (comma) PrintF(", ");
-      PrintF("forced context allocation");
-      comma = true;
-    }
-    if (var->maybe_assigned() == kNotAssigned) {
-      if (comma) PrintF(", ");
-      PrintF("never assigned");
-    }
-    PrintF("\n");
+  Indent(indent, VariableMode2String(var->mode()));
+  PrintF(" ");
+  if (var->raw_name()->IsEmpty())
+    PrintF(".%p", reinterpret_cast<void*>(var));
+  else
+    PrintName(var->raw_name());
+  PrintF(";  // ");
+  PrintLocation(var);
+  bool comma = !var->IsUnallocated();
+  if (var->has_forced_context_allocation()) {
+    if (comma) PrintF(", ");
+    PrintF("forced context allocation");
+    comma = true;
   }
+  if (var->maybe_assigned() == kNotAssigned) {
+    if (comma) PrintF(", ");
+    PrintF("never assigned");
+  }
+  PrintF("\n");
 }
 
-static void PrintMap(int indent, VariableMap* map, bool locals) {
+static void PrintMap(int indent, const char* label, VariableMap* map,

[Igor Sheludko, 2016/12/02 22:06:10]

Same here.

[adamk, 2016/12/03 00:04:23]

Done.

+                     bool locals, Variable* function_var) {
+  bool printed_label = false;
   for (VariableMap::Entry* p = map->Start(); p != nullptr; p = map->Next(p)) {
     Variable* var = reinterpret_cast<Variable*>(p->value);
+    if (var == function_var) continue;
     bool local = !IsDynamicVariableMode(var->mode());
-    if (locals ? local : !local) {
-      if (var == nullptr) {
-        Indent(indent, "<?>\n");
-      } else {
-        PrintVar(indent, var);
+    if ((locals ? local : !local) &&
+        (var->is_used() || !var->IsUnallocated())) {
+      if (!printed_label) {
+        Indent(indent, label);
+        printed_label = true;
       }
+      PrintVar(indent, var);
     }
   }
 }
 
 void DeclarationScope::PrintParameters() {
   PrintF(" (");
   for (int i = 0; i < params_.length(); i++) {
     if (i > 0) PrintF(", ");
     const AstRawString* name = params_[i]->raw_name();
     if (name->IsEmpty())
@@ skipping 58 matching lines @@
     Indent(n1, "// ");
     PrintF("%d heap slots\n", num_heap_slots_);
   }
 
   // Print locals.
   if (function != nullptr) {
     Indent(n1, "// function var:\n");
     PrintVar(n1, function);
   }
 
-  if (variables_.occupancy() != 0) {
-    Indent(n1, "// local vars:\n");
-    PrintMap(n1, &variables_, true);
-
-    Indent(n1, "// dynamic vars:\n");
-    PrintMap(n1, &variables_, false);
-  }
+  PrintMap(n1, "// local vars:\n", &variables_, true, function);
+  PrintMap(n1, "// dynamic vars:\n", &variables_, false, function);
 
   // Print inner scopes (disable by providing negative n).
   if (n >= 0) {
     for (Scope* scope = inner_scope_; scope != nullptr;
          scope = scope->sibling_) {
       PrintF("\n");
       scope->Print(n1);
     }
   }
 
@@ skipping 541 matching lines @@
   Variable* function =
       is_function_scope() ? AsDeclarationScope()->function_var() : nullptr;
   bool is_function_var_in_context =
       function != nullptr && function->IsContextSlot();
   return num_heap_slots() - Context::MIN_CONTEXT_SLOTS -
          (is_function_var_in_context ? 1 : 0);
 }
 
 }  // namespace internal
 }  // namespace v8