Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2543903002: [TTS] Remove an assert in OverlayPanelContent for intents. (Closed)

Created:
4 years ago by Donn Denman
Modified:
4 years ago
Reviewers:
Jinsuk Kim
CC:
chromium-reviews, mdjones+watch_chromium.org, donnd+watch_chromium.org, agrieve+watch_chromium.org, twellington+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Remove an assert in OverlayPanelContent for intents. Just removing the assert. BUG=670158 Committed: https://crrev.com/579f7b52dc783c5a56c0922450245f51abfed862 Cr-Commit-Position: refs/heads/master@{#435674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Donn Denman
Jinsuk, PTAL at removing this assert that you added several months ago. We've adding a ...
4 years ago (2016-12-01 03:15:02 UTC) #2
Jinsuk Kim
lgtm
4 years ago (2016-12-01 03:43:40 UTC) #3
Jinsuk Kim
On 2016/12/01 03:43:40, Jinsuk Kim wrote: > lgtm But is it still okay for acquireView() ...
4 years ago (2016-12-01 03:48:32 UTC) #4
Donn Denman
I'll work to verify that it's OK to return null to aquireView, and also to ...
4 years ago (2016-12-01 16:57:03 UTC) #5
Donn Denman
I'll work to verify that it's OK to return null to aquireView, and also to ...
4 years ago (2016-12-01 16:57:05 UTC) #6
Donn Denman
Looks like it's safe to land this, submitting now. As noted in the bug: We're ...
4 years ago (2016-12-01 18:48:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543903002/1
4 years ago (2016-12-01 18:49:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 19:25:13 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-01 19:29:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/579f7b52dc783c5a56c0922450245f51abfed862
Cr-Commit-Position: refs/heads/master@{#435674}

Powered by Google App Engine
This is Rietveld 408576698