[TTS] Remove an assert in OverlayPanelContent for intents.

[TTS] Remove an assert in OverlayPanelContent for intents.

Just removing the assert.

BUG=670158
Committed: https://crrev.com/579f7b52dc783c5a56c0922450245f51abfed862
Cr-Commit-Position: refs/heads/master@{#435674}

[Donn Denman, 2016-12-01 03:15:02]

donnd@chromium.org changed reviewers:
+ jinsukkim@chromium.org

[Donn Denman, 2016-12-01 03:15:02]

Jinsuk, PTAL at removing this assert that you added several months ago.  

We've adding a new feature for Contextual Search that draws feedback in the
overlay panel when you tap and there's a "Quick Action" intent there.  Looks
like this feedback causes aquireView to be called.

[Jinsuk Kim, 2016-12-01 03:43:40]

lgtm

[Jinsuk Kim, 2016-12-01 03:48:32]

On 2016/12/01 03:43:40, Jinsuk Kim wrote:
> lgtm

But is it still okay for acquireView() to simply return without doing nothing?

[Donn Denman, 2016-12-01 16:57:03]

I'll work to verify that it's OK to return null to aquireView, and also to
understand why Theresa didn't see this when the Quick Actions were originally
landed.  Will update this CL and/or the bug before landing.

[Donn Denman, 2016-12-01 16:57:05]

I'll work to verify that it's OK to return null to aquireView, and also to
understand why Theresa didn't see this when the Quick Actions were originally
landed.  Will update this CL and/or the bug before landing.

[Donn Denman, 2016-12-01 18:48:42]

Looks like it's safe to land this, submitting now.

As noted in the bug:
We're seeing this now because asserts were enabled on Android L+ on 11/23/16 in
https://codereview.chromium.org/2517203002.

Looks like it's fine to return null because ViewAndroidDelegate returns null in
some cases where it can't create a view.

[Donn Denman, 2016-12-01 18:48:49]

The CQ bit was checked by donnd@chromium.org

[commit-bot: I haz the power, 2016-12-01 18:49:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 19:24:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480618129637290, "parent_rev":
"9cecc6504b0d5a29370477dc9343a9ea83704666", "commit_rev":
"63f79629b33e2d68319db28dd82b9d77ad70de34"}

[commit-bot: I haz the power, 2016-12-01 19:25:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-01 19:29:56]

Description was changed from

==========
[TTS] Remove an assert in OverlayPanelContent for intents.

Just removing the assert.

BUG=670158
==========

to

==========
[TTS] Remove an assert in OverlayPanelContent for intents.

Just removing the assert.

BUG=670158

Committed: https://crrev.com/579f7b52dc783c5a56c0922450245f51abfed862
Cr-Commit-Position: refs/heads/master@{#435674}
==========

[commit-bot: I haz the power, 2016-12-01 19:29:57]

Patchset 1 (id:??) landed as
https://crrev.com/579f7b52dc783c5a56c0922450245f51abfed862
Cr-Commit-Position: refs/heads/master@{#435674}