Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 2543893002: Reuse InputConnectionHandlerThread (Closed)

4 years ago by Changwan Ryu
4 years ago
chromium-reviews, jam,,, Ted C
Target Ref:


Reuse InputConnectionHandlerThread This can prevent the number of threads from growing when an app creates and destroys webviews. BUG=668692 Committed: Cr-Commit-Position: refs/heads/master@{#435557}

Patch Set 1 #

Patch Set 2 : fixed findit failure #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/ View 1 3 chunks +12 lines, -4 lines 6 comments Download


Total messages: 17 (9 generated)
Changwan Ryu
yabinh@, could you take a quick look at this CL?
4 years ago (2016-12-01 02:21:21 UTC) #4
non-owner lgtm
4 years ago (2016-12-01 02:40:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at
4 years ago (2016-12-01 04:29:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 05:08:24 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as Cr-Commit-Position: refs/heads/master@{#435557}
4 years ago (2016-12-01 05:12:10 UTC) #14
Thanks for the simpler fix. Some post-commit minor comments that are fine to address in ...
4 years ago (2016-12-01 11:01:59 UTC) #15
Changwan Ryu
Uploaded as a clean-up / follow-up. File content/public/android/java/src/org/chromium/content/browser/input/ (right): content/public/android/java/src/org/chromium/content/browser/input/ // Reused ...
4 years ago (2016-12-02 09:06:49 UTC) #16
4 years ago (2016-12-02 12:13:09 UTC) #17
Message was sent while issue was closed.
On 2016/12/02 09:06:49, Changwan Ryu wrote:
> I'll go ahead with option 2). I didn't realize that I can use static
> inside the initialization-on-demand holder, and was worried that structure may
> be too complicated. Now I've uploaded a follow-up CL.

Yup. Java just compiles static initialiser blocks and any initialiser
expressions on static field declarations into one big class-init method, and
calls that class-init method in a magically threadsafe way for you when the
class is referenced :)

Powered by Google App Engine
This is Rietveld 408576698