Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1483)

Issue 2543873003: [stubs] Use CSA::IsHeapNumberMap() instead of manual map comparing. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Use CSA::IsHeapNumberMap() instead of manual map comparing. Bonus: fixed a couple of places where 32-bit comparison was used. BUG= Committed: https://crrev.com/fce55b528f0339c61a8ff732bc3120e60595499f Cr-Commit-Position: refs/heads/master@{#41417}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -123 lines) Patch
M src/builtins/builtins-array.cc View 11 chunks +23 lines, -27 lines 0 comments Download
M src/builtins/builtins-conversion.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/builtins/builtins-global.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/builtins/builtins-math.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M src/builtins/builtins-number.cc View 14 chunks +11 lines, -23 lines 0 comments Download
M src/builtins/builtins-string.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/code-stub-assembler.cc View 20 chunks +20 lines, -33 lines 2 comments Download
M src/code-stubs.cc View 12 chunks +9 lines, -15 lines 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Igor Sheludko
Benedikt, PTAL @ interpreter Jakob, PTAL @ the rest https://codereview.chromium.org/2543873003/diff/1/src/code-stub-assembler.cc File src/code-stub-assembler.cc (left): https://codereview.chromium.org/2543873003/diff/1/src/code-stub-assembler.cc#oldcode3779 src/code-stub-assembler.cc:3779: ...
4 years ago (2016-12-01 09:48:33 UTC) #5
Benedikt Meurer
LGTM on interpreter.
4 years ago (2016-12-01 09:49:37 UTC) #6
jgruber
Nice, lgtm
4 years ago (2016-12-01 10:01:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543873003/1
4 years ago (2016-12-01 10:04:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 10:15:53 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-01 10:16:20 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fce55b528f0339c61a8ff732bc3120e60595499f
Cr-Commit-Position: refs/heads/master@{#41417}

Powered by Google App Engine
This is Rietveld 408576698