Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: src/interpreter/interpreter.cc

Issue 2543873003: [stubs] Use CSA::IsHeapNumberMap() instead of manual map comparing. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/interpreter.cc
diff --git a/src/interpreter/interpreter.cc b/src/interpreter/interpreter.cc
index bb731b455bf4afa740027200449273555cdb45bf..b5e81206b53a315a156ba5ae9fd8fdd8db6690ee 100644
--- a/src/interpreter/interpreter.cc
+++ b/src/interpreter/interpreter.cc
@@ -1047,8 +1047,7 @@ void Interpreter::DoCompareOpWithFeedback(Token::Value compare_op,
__ Bind(&lhs_is_not_smi);
{
Node* lhs_map = __ LoadMap(lhs);
- __ GotoUnless(__ WordEqual(lhs_map, __ HeapNumberMapConstant()),
- &lhs_is_not_number);
+ __ GotoUnless(__ IsHeapNumberMap(lhs_map), &lhs_is_not_number);
var_type_feedback.Bind(
__ Int32Constant(CompareOperationFeedback::kNumber));
@@ -1092,8 +1091,7 @@ void Interpreter::DoCompareOpWithFeedback(Token::Value compare_op,
__ Bind(&rhs_is_not_smi);
{
Node* rhs_map = __ LoadMap(rhs);
- __ GotoUnless(__ WordEqual(rhs_map, __ HeapNumberMapConstant()),
- &rhs_is_not_number);
+ __ GotoUnless(__ IsHeapNumberMap(rhs_map), &rhs_is_not_number);
var_type_feedback.Bind(
__ Word32Or(var_type_feedback.value(),

Powered by Google App Engine
This is Rietveld 408576698