Issue 2543793003: Add UMA metrics to measure the dismissal cause of dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2543793003: Add UMA metrics to measure the dismissal cause of dialogs. (Closed)

Created:
4 years ago by Avi (use Gerrit)

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Add UMA metrics to measure the dismissal cause of dialogs. BUG=629964 Review-Url: https://codereview.chromium.org/2535043002 Cr-Commit-Position: refs/heads/master@{#435016} (cherry picked from commit 70f9ea001b21e3ad255fe0d2bb7822d8e52789b7) Committed: https://chromium.googlesource.com/chromium/src/+/511f20e8743d2d5ef2b9ab812fb37428a9c3669c

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -11 lines)			Patch
M	chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc	View	6 chunks	+56 lines, -10 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	3 chunks	+34 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Avi (use Gerrit)

4 years ago (2016-12-01 16:15:54 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
511f20e8743d2d5ef2b9ab812fb37428a9c3669c.