Add UMA metrics to measure the dismissal cause of dialogs.

Add UMA metrics to measure the dismissal cause of dialogs.

BUG=629964
Committed: https://crrev.com/70f9ea001b21e3ad255fe0d2bb7822d8e52789b7
Cr-Commit-Position: refs/heads/master@{#435016}

[Avi (use Gerrit), 2016-11-28 19:31:23]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 19:33:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-11-28 20:13:45]

avi@chromium.org changed reviewers:
+ isherman@chromium.org, ojan@chromium.org

[Avi (use Gerrit), 2016-11-28 20:13:46]

Ojan, as in our thread with Kenji, this should give us metrics of how this turns
out.

[ojan, 2016-11-28 21:48:26]

lgtm

[commit-bot: I haz the power, 2016-11-28 21:50:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 21:51:00]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-11-29 03:10:35]

metrics lgtm

https://codereview.chromium.org/2535043002/diff/1/chrome/browser/ui/javascrip...
File chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
(right):

https://codereview.chromium.org/2535043002/diff/1/chrome/browser/ui/javascrip...
chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc:59: enum
class JavaScriptDialogTabHelper::DismissalCause {
Please document that this enum is used to back an UMA histogram, and should
therefore be treated as append-only.

https://codereview.chromium.org/2535043002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2535043002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:90285: +  <int value="6" label="The user
clicked on the OK or Cancel button"/>
Optional: These labels are pretty long, and might be hard to read in the
dashboard UI.  You might want to provide shorter labels, with longform hover
text, like so:

<int value="6" label="OK/Cancel button">The user clicked on the OK or Cancel
button</int>

[Avi (use Gerrit), 2016-11-29 16:10:59]

https://codereview.chromium.org/2535043002/diff/1/chrome/browser/ui/javascrip...
File chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
(right):

https://codereview.chromium.org/2535043002/diff/1/chrome/browser/ui/javascrip...
chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc:59: enum
class JavaScriptDialogTabHelper::DismissalCause {
On 2016/11/29 03:10:35, Ilya Sherman wrote:
> Please document that this enum is used to back an UMA histogram, and should
> therefore be treated as append-only.

Done.

https://codereview.chromium.org/2535043002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2535043002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:90285: +  <int value="6" label="The user
clicked on the OK or Cancel button"/>
On 2016/11/29 03:10:35, Ilya Sherman wrote:
> Optional: These labels are pretty long, and might be hard to read in the
> dashboard UI.  You might want to provide shorter labels, with longform hover
> text, like so:
> 
> <int value="6" label="OK/Cancel button">The user clicked on the OK or Cancel
> button</int>

I didn't know that was possible! Done.

[Avi (use Gerrit), 2016-11-29 16:14:03]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-11-29 16:14:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, ojan@chromium.org
Link to the patchset: https://codereview.chromium.org/2535043002/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2016-11-29 16:14:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 17:15:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480436043092710,
"parent_rev": "2e918f6b58f4a41ac386999d2c7f06a245aa8761", "commit_rev":
"71217f929a9a7d0663e59b425efc91adfc1d26ed"}

[commit-bot: I haz the power, 2016-11-29 17:16:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 17:18:46]

Description was changed from

==========
Add UMA metrics to measure the dismissal cause of dialogs.

BUG=629964
==========

to

==========
Add UMA metrics to measure the dismissal cause of dialogs.

BUG=629964

Committed: https://crrev.com/70f9ea001b21e3ad255fe0d2bb7822d8e52789b7
Cr-Commit-Position: refs/heads/master@{#435016}
==========

[commit-bot: I haz the power, 2016-11-29 17:18:47]

Patchset 2 (id:??) landed as
https://crrev.com/70f9ea001b21e3ad255fe0d2bb7822d8e52789b7
Cr-Commit-Position: refs/heads/master@{#435016}