Added setting up VMLibraryHooks for Dartium to support resolvePageUri

Source/bindings/core/dart/DartController.cpp

 // Copyright (c) 2009, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 152 matching lines @@
     // FIXME: this should be blinkSnapshotResolver
     Dart_SetNativeResolver(blink, isDOMEnabled ? domIsolateHtmlResolver : pureIsolateResolver, isDOMEnabled ? domIsolateHtmlSymbolizer : pureIsolateSymbolizer);
     domData->setBlinkLibrary(Dart_NewPersistentHandle(blink));
 
     // Fix the html library.
     Dart_Handle html = Dart_LookupLibrary(Dart_NewStringFromCString("dart:html"));
     ASSERT(!Dart_IsError(html));
     Dart_SetNativeResolver(html, isDOMEnabled ? domIsolateHtmlResolver : pureIsolateResolver, isDOMEnabled ? domIsolateHtmlSymbolizer : pureIsolateSymbolizer);
     domData->setHtmlLibrary(Dart_NewPersistentHandle(html));
 
+    // Lookup native calls referenced in dart:_builtin for _setupHooks() to setup VMLibraryHooks.
+    Dart_Handle builtin = Dart_LookupLibrary(Dart_NewStringFromCString("dart:_builtin"));
+    ASSERT(!Dart_IsError(builtin));
+    Dart_SetNativeResolver(builtin, isDOMEnabled ? domIsolateHtmlResolver : pureIsolateResolver, isDOMEnabled ? domIsolateHtmlSymbolizer : pureIsolateSymbolizer);
+    domData->setBuiltinLibrary(Dart_NewPersistentHandle(builtin));

[siva, 2017/01/06 21:39:33]

Ditto comment about not needing this if the setup code is in one of the other
libraries.

[terry, 2017/01/09 21:06:02]

Right native resolver is removed (code exist in dart:_blink).

+
     Dart_Handle js = Dart_LookupLibrary(Dart_NewStringFromCString("dart:js"));
     ASSERT(!Dart_IsError(js));
     Dart_SetNativeResolver(js, isDOMEnabled ? JsInterop::resolver : pureIsolateResolver, 0);
     domData->setJsLibrary(Dart_NewPersistentHandle(js));
 
     Dart_Handle core = Dart_LookupLibrary(Dart_NewStringFromCString("dart:core"));
     ASSERT(!Dart_IsError(core));
 
     domData->setSvgLibrary(0);
 
@@ skipping 554 matching lines @@
     init_params.version = DART_INITIALIZE_PARAMS_CURRENT_VERSION;
     init_params.vm_isolate_snapshot = DartUtilities::vmIsolateSnapshot();
     init_params.create =  &createPureIsolateCallback;
     init_params.file_open = openFileCallback;
     init_params.file_read = readFileCallback;
     init_params.file_write = writeFileCallback;
     init_params.file_close = closeFileCallback;
     init_params.entropy_source = generateEntropy;
     init_params.get_service_assets = GetVMServiceAssetsArchiveCallback;
     char* error = Dart_Initialize(&init_params);
-    RELEASE_ASSERT_WITH_MESSAGE(!error, error);
+    RELEASE_ASSERT_WITH_MESSAGE(!error, "Dart_Initialize failed");
 }
 
 static bool checkForExpiration()
 {
     const time_t ExpirationTimeSecsSinceEpoch =
 #include "bindings/dart/ExpirationTimeSecsSinceEpoch.time_t"
     ;
     const char* override = getenv("DARTIUM_EXPIRATION_TIME");
     time_t expiration;
     if (override) {
@@ skipping 252 matching lines @@
     Dart_ExitIsolate();
     loader->processSingleRequest(isolate, url, callback);
 
     // Restore caller isolate.
     Dart_EnterIsolate(caller);
 
     // FIXME: We need some way to return a Dart_Handle to the isolate we just created.
 }
 
 }