Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2543643006: Split a mixed-content promise test into separate ones. (Closed)

Created:
4 years ago by yhirano
Modified:
3 years, 11 months ago
Reviewers:
hiroshige
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split a mixed-content promise test into separate ones. BUG=None Review-Url: https://codereview.chromium.org/2543643006 Cr-Commit-Position: refs/heads/master@{#443153} Committed: https://chromium.googlesource.com/chromium/src/+/4d4cfc11f9295e7bb7126d2647d9e588e0349d96

Patch Set 1 #

Patch Set 2 : done? #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -61 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/fetch/resources/fetch-test-helpers.js View 1 2 1 chunk +41 lines, -61 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
yhirano
4 years ago (2016-12-02 06:50:29 UTC) #8
yhirano
On 2016/12/02 06:50:29, yhirano wrote: ping.
3 years, 11 months ago (2017-01-11 10:25:20 UTC) #11
hiroshige
lgtm
3 years, 11 months ago (2017-01-12 00:11:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543643006/40001
3 years, 11 months ago (2017-01-12 03:42:17 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 04:45:26 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4d4cfc11f9295e7bb7126d2647d9...

Powered by Google App Engine
This is Rietveld 408576698