Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2543493003:
webrtc-internals: add useragent to JSON dump (Closed)
Descriptionwebrtc-internals: add useragent to JSON dump
this adds the user agent to the dump. This allows identifying
the chrome version from the dump.
BUG=
Committed: https://crrev.com/aeee6931a2d92194c6e7c85f966e40b246852e61
Cr-Commit-Position: refs/heads/master@{#437876}
Patch Set 1 #
Total comments: 1
Patch Set 2 : s/User-Agent/UserAgent/ #Messages
Total messages: 23 (12 generated)
Description was changed from ========== webrtc-internals: add useragent to JSON dump this adds the user agent to the dump. This allows identifying the chrome version from the dump. BUG= ========== to ========== webrtc-internals: add useragent to JSON dump this adds the user agent to the dump. This allows identifying the chrome version from the dump. BUG= ==========
philipp.hancke@googlemail.com changed reviewers: + hta@webrtc.org, tommi@webrtc.org
authors change is in https://codereview.chromium.org/2495983002/
lgtm lgtm https://codereview.chromium.org/2543493003/diff/1/content/browser/resources/m... File content/browser/resources/media/dump_creator.js (right): https://codereview.chromium.org/2543493003/diff/1/content/browser/resources/m... content/browser/resources/media/dump_creator.js:121: 'User-Agent': navigator.userAgent, Nit: Can we make it "UserAgent"? My head hurts every time I mix in Yet Another Naming Style.
tommi@chromium.org changed reviewers: + tommi@chromium.org
The CQ bit was checked by tommi@chromium.org
lgtm
The patchset sent to the CQ was uploaded after l-g-t-m from hta@webrtc.org Link to the patchset: https://codereview.chromium.org/2543493003/#ps20001 (title: "s/User-Agent/UserAgent/")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2016/12/07 16:45:05, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) philipp.hancke@googlemail.com needs to be in the AUTHORS file before we can commit.
The CQ bit was checked by tommi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by tommi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481555995422560,
"parent_rev": "04d5ecb8bdd95dcafb5d0a83a775a7f85be7f090", "commit_rev":
"468b6b979de218297cc093dce640cb0c16359f44"}
Message was sent while issue was closed.
Description was changed from ========== webrtc-internals: add useragent to JSON dump this adds the user agent to the dump. This allows identifying the chrome version from the dump. BUG= ========== to ========== webrtc-internals: add useragent to JSON dump this adds the user agent to the dump. This allows identifying the chrome version from the dump. BUG= Review-Url: https://codereview.chromium.org/2543493003 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== webrtc-internals: add useragent to JSON dump this adds the user agent to the dump. This allows identifying the chrome version from the dump. BUG= Review-Url: https://codereview.chromium.org/2543493003 ========== to ========== webrtc-internals: add useragent to JSON dump this adds the user agent to the dump. This allows identifying the chrome version from the dump. BUG= Committed: https://crrev.com/aeee6931a2d92194c6e7c85f966e40b246852e61 Cr-Commit-Position: refs/heads/master@{#437876} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/aeee6931a2d92194c6e7c85f966e40b246852e61 Cr-Commit-Position: refs/heads/master@{#437876} |
