Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2543353002: Fix V8 bindings for LongTaskObserver origin trial (Closed)

Created:
4 years ago by chasej
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fix V8 bindings for LongTaskObserver origin trial Currently, exposing a JavaScript API change as an origin trial requires manual code changes to V8 bindings. The necessary binding changes were missing when Long Task Observer was integrated with the origin trials framework. This CL adds the missing call to the generated method: V8Window::installLongTaskObserver() BUG=667795 Review-Url: https://codereview.chromium.org/2533793003 Cr-Commit-Position: refs/heads/master@{#435515} (cherry picked from commit e72c2aa444360ae4f3eea4e923aeb0130e081dd2) Committed: https://chromium.googlesource.com/chromium/src/+/6c7764973a6167d34a1cff70cf67800734f8f52c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
chasej
4 years ago (2016-12-02 21:00:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6c7764973a6167d34a1cff70cf67800734f8f52c.

Powered by Google App Engine
This is Rietveld 408576698