Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2533793003:
Fix V8 bindings for LongTaskObserver origin trial (Closed)
DescriptionFix V8 bindings for LongTaskObserver origin trial
Currently, exposing a JavaScript API change as an origin trial requires
manual code changes to V8 bindings. The necessary binding changes were
missing when Long Task Observer was integrated with the origin trials
framework.
This CL adds the missing call to the generated method:
V8Window::installLongTaskObserver()
BUG=667795
Committed: https://crrev.com/e72c2aa444360ae4f3eea4e923aeb0130e081dd2
Cr-Commit-Position: refs/heads/master@{#435515}
Patch Set 1 #Patch Set 2 : Minor code cleanup #Patch Set 3 : Rebase #Patch Set 4 : Correct layout test expectations for global interfaces #Patch Set 5 : Add recent attributes to test expectations #
Messages
Total messages: 27 (19 generated)
The CQ bit was checked by chasej@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
chasej@chromium.org changed reviewers: + iclelland@chromium.org
iclelland, please take a look.
Implementation-wise LGTM
LGTM, thanks!
The CQ bit was checked by chasej@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by chasej@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by chasej@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by chasej@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by chasej@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, iclelland@chromium.org Link to the patchset: https://codereview.chromium.org/2533793003/#ps80001 (title: "Add recent attributes to test expectations")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480554802918790,
"parent_rev": "9f452a1dbe8610ae53020ffa836118600a835f64", "commit_rev":
"cff6272fc6ace2164fc887b022db940395b908cb"}
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Fix V8 bindings for LongTaskObserver origin trial Currently, exposing a JavaScript API change as an origin trial requires manual code changes to V8 bindings. The necessary binding changes were missing when Long Task Observer was integrated with the origin trials framework. This CL adds the missing call to the generated method: V8Window::installLongTaskObserver() BUG=667795 ========== to ========== Fix V8 bindings for LongTaskObserver origin trial Currently, exposing a JavaScript API change as an origin trial requires manual code changes to V8 bindings. The necessary binding changes were missing when Long Task Observer was integrated with the origin trials framework. This CL adds the missing call to the generated method: V8Window::installLongTaskObserver() BUG=667795 Committed: https://crrev.com/e72c2aa444360ae4f3eea4e923aeb0130e081dd2 Cr-Commit-Position: refs/heads/master@{#435515} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/e72c2aa444360ae4f3eea4e923aeb0130e081dd2 Cr-Commit-Position: refs/heads/master@{#435515} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
