Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2543343002: DevTools: omit remoteBase query param when starting a shared worker (Closed)

Created:
4 years ago by caseq
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: omit remoteBase query param when starting a shared worker Shared workers can't be started with mismatching URLs, so strip remoteBase when starting a shared worker. Committed: https://crrev.com/9008feb1e26578cfd503ecc196adaf6ffd080a49 Cr-Commit-Position: refs/heads/master@{#436408}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 14 (6 generated)
caseq
4 years ago (2016-12-02 19:51:53 UTC) #2
dgozman
https://codereview.chromium.org/2543343002/diff/1/third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js File third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js (right): https://codereview.chromium.org/2543343002/diff/1/third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js#newcode39 third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js:39: var worker = isSharedWorker ? new SharedWorker(url, appName) : ...
4 years ago (2016-12-02 19:55:53 UTC) #3
dgozman
lgtm per offline discussion
4 years ago (2016-12-02 20:19:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543343002/1
4 years ago (2016-12-02 21:28:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/343172)
4 years ago (2016-12-03 01:19:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543343002/1
4 years ago (2016-12-05 19:01:13 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 21:22:01 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-05 21:24:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9008feb1e26578cfd503ecc196adaf6ffd080a49
Cr-Commit-Position: refs/heads/master@{#436408}

Powered by Google App Engine
This is Rietveld 408576698