Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1814)

Unified Diff: third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js

Issue 2543343002: DevTools: omit remoteBase query param when starting a shared worker (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js b/third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js
index f55a4bd2ba78c5c0dbc8d48c5bc25f9da81079d9..0d08aeda73549fd6d7344c8754ca05bb651cda62 100644
--- a/third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js
@@ -31,7 +31,9 @@ Services.ServiceManager = class {
createAppService(appName, serviceName, isSharedWorker) {
var url = appName + '.js';
var remoteBase = Runtime.queryParam('remoteBase');
- if (remoteBase)
+ // Do not pass additional query parameters to shared worker to avoid URLMismatchError
+ // in case another instance of DevTools with different remoteBase creates same shared worker.
+ if (remoteBase && !isSharedWorker)
url += '?remoteBase=' + remoteBase;
var worker = isSharedWorker ? new SharedWorker(url, appName) : new Worker(url);
dgozman 2016/12/02 19:55:53 Should we instead pass different appName for diffe
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698