Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 254333003: Eliminate SkPicture-related flags Chromium no longer requires (Closed)

Created:
6 years, 7 months ago by robertphillips
Modified:
6 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com, caryclark
Visibility:
Public.

Description

Eliminate SkPicture-related flags Chromium no longer requires This was originally reverted in r14349 (Restore SkPicture-related guard flags for Chrome - https://codereview.chromium.org/255543004/) due to Android WebView compile failures. These failures should be fixed in Chromium r267210 (Fixing Chromium Android build's reliance on old SkPicture recording API - https://codereview.chromium.org/251843005/) Committed: http://code.google.com/p/skia/source/detail?r=14471

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M gyp/skia_for_chromium_defines.gypi View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
6 years, 7 months ago (2014-04-30 15:43:25 UTC) #1
bsalomon
lgtm
6 years, 7 months ago (2014-04-30 15:46:38 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 7 months ago (2014-04-30 15:47:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/254333003/1
6 years, 7 months ago (2014-04-30 15:47:16 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 15:55:17 UTC) #5
Message was sent while issue was closed.
Change committed as 14471

Powered by Google App Engine
This is Rietveld 408576698