Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 251843005: Fixing Chromium Android build's reliance on old SkPicture recording API (Closed)

Created:
6 years, 7 months ago by robertphillips
Modified:
6 years, 7 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Fixing Chromium Android build's reliance on old SkPicture recording API Skia is moving to an API where SkPicture can no longer invoke beginRecording/endRecording on itself. This functionality is deferred to a separate SkPictureRecorder object to clarify when SkPictures are complete (and make them immutable). This CL updates webview to the new interface. torne for OWNER review fmalita for skia-side review Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267210

Patch Set 1 #

Patch Set 2 : Updated #

Patch Set 3 : fix git hash #

Patch Set 4 : Fix fix #

Patch Set 5 : Remove DEPS file changes #

Total comments: 2

Patch Set 6 : Addressed code review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M android_webview/browser/browser_view_renderer.cc View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
robertphillips
6 years, 7 months ago (2014-04-29 15:35:53 UTC) #1
f(malita)
Non-owner lgtm + nit. https://codereview.chromium.org/251843005/diff/80001/android_webview/browser/browser_view_renderer.cc File android_webview/browser/browser_view_renderer.cc (right): https://codereview.chromium.org/251843005/diff/80001/android_webview/browser/browser_view_renderer.cc#newcode164 android_webview/browser/browser_view_renderer.cc:164: skia::RefPtr<SkPicture> picture(skia::AdoptRef(recorder.endRecording())); return skia::AdoptRef(recorder.endRecording());
6 years, 7 months ago (2014-04-29 17:26:59 UTC) #2
boliu
owner lgtm
6 years, 7 months ago (2014-04-29 18:12:53 UTC) #3
robertphillips
https://codereview.chromium.org/251843005/diff/80001/android_webview/browser/browser_view_renderer.cc File android_webview/browser/browser_view_renderer.cc (right): https://codereview.chromium.org/251843005/diff/80001/android_webview/browser/browser_view_renderer.cc#newcode164 android_webview/browser/browser_view_renderer.cc:164: skia::RefPtr<SkPicture> picture(skia::AdoptRef(recorder.endRecording())); On 2014/04/29 17:26:59, Florin Malita wrote: > ...
6 years, 7 months ago (2014-04-29 19:14:31 UTC) #4
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 7 months ago (2014-04-29 19:14:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertphillips@google.com/251843005/100001
6 years, 7 months ago (2014-04-29 19:16:51 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 19:29:34 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium
6 years, 7 months ago (2014-04-29 19:29:35 UTC) #8
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 7 months ago (2014-04-30 11:51:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertphillips@google.com/251843005/100001
6 years, 7 months ago (2014-04-30 11:51:41 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 12:14:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-04-30 12:14:27 UTC) #12
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 7 months ago (2014-04-30 12:20:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertphillips@google.com/251843005/100001
6 years, 7 months ago (2014-04-30 12:20:52 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 14:55:04 UTC) #15
Message was sent while issue was closed.
Change committed as 267210

Powered by Google App Engine
This is Rietveld 408576698