Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2543303002: DevTools: rebaseline tests after V8 roll (Closed)

Created:
4 years ago by luoe
Modified:
4 years ago
Reviewers:
kozy, dgozman
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: rebaseline tests after V8 roll Test expectations were modified for tests that included the old format for descriptions 'Array[2]'. Since the V8 change landed that updated descriptions to 'Array(2)', this CL manually rebaselines the tests that failed. CLs that marked expectations: https://codereview.chromium.org/2524913002/ https://codereview.chromium.org/2550513002/ BUG=405845 Committed: https://crrev.com/a464b6447319d296f677b4250c1b0d858eb3ed5e Cr-Commit-Position: refs/heads/master@{#436036}

Patch Set 1 #

Patch Set 2 : DevTools: rebaseline expectations after injected script source change #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -331 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +1 line, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-big-array-expected.txt View 7 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-dir-es6-expected.txt View 6 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-edit-property-value-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-external-array-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-collections-expected.txt View 2 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-es6-2-expected.txt View 6 chunks +40 lines, -40 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-es6-expected.txt View 3 chunks +90 lines, -90 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt View 15 chunks +115 lines, -115 lines 2 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-object-preview-expected.txt View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-minified-variables-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/properties-special-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
luoe
@kozyatinskiy: In console-format-expected.html, there was a change to the precision of digits in the CONSOLE ...
4 years ago (2016-12-02 19:39:36 UTC) #8
dgozman
lgtm
4 years ago (2016-12-02 19:41:56 UTC) #9
kozy
lgtm https://codereview.chromium.org/2543303002/diff/20001/third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt File third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt (right): https://codereview.chromium.org/2543303002/diff/20001/third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt#newcode84 third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt:84: CONSOLE MESSAGE: line 13: 42.0000 On 2016/12/02 19:39:36, ...
4 years ago (2016-12-02 21:21:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543303002/20001
4 years ago (2016-12-02 21:25:54 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-02 21:35:17 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-02 21:38:05 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a464b6447319d296f677b4250c1b0d858eb3ed5e
Cr-Commit-Position: refs/heads/master@{#436036}

Powered by Google App Engine
This is Rietveld 408576698