Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

Issue 2543303002: DevTools: rebaseline tests after V8 roll (Closed)
Patch Set: DevTools: rebaseline expectations after injected script source change Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
index df07d56fb9ff9f543e1b2b349cc30c23e0ad89e8..efc30fd9f8e8525818f3029c82a653ca3199ec89 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
@@ -70,6 +70,8 @@ SDK.RemoteObject = class {
static arrayLength(object) {
if (object.subtype !== 'array' && object.subtype !== 'typedarray')
return 0;
+ // Array lengths in V8-generated descriptions switched from square brackets to parentheses.
+ // Both formats are checked in case the front end is dealing with an old version of V8.
var matches = object.description.match(/\[([0-9]+)\]/) || object.description.match(/\(([0-9]+)\)/);
if (!matches)
return 0;

Powered by Google App Engine
This is Rietveld 408576698