Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-margins-and-orthogonal-flows.html

Issue 2543193002: [css-grid] Use child's marginLogicalWidth to compute content-sized track (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-margins-and-orthogonal-flows.html
diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-margins-and-orthogonal-flows.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-margins-and-orthogonal-flows.html
new file mode 100644
index 0000000000000000000000000000000000000000..294d006c33087992b143d5ebdbf0b54fb575aec1
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-margins-and-orthogonal-flows.html
@@ -0,0 +1,61 @@
+<!DOCTYPE html>
+<link href="resources/grid.css" rel="stylesheet">
+<link href="resources/grid-alignment.css" rel="stylesheet">
+<link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel="stylesheet">
+<style>
+body { margin: 0; }
Manuel Rego 2016/12/02 12:30:47 I don't think you need this.
jfernandez 2016/12/02 13:36:07 Done.
+.grid { font: 20px/1 Ahem; }
+.row { grid-auto-flow: column; }
Manuel Rego 2016/12/02 12:30:47 Nit: This is already defined in grid.css: "gridAut
jfernandez 2016/12/02 13:36:07 Done.
+.item { margin: 10px 5px 5px 15px; }
Manuel Rego 2016/12/02 12:30:47 Nit: Extra space "{ margin".
jfernandez 2016/12/02 13:36:06 Done.
+</style>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<script src="../../resources/check-layout-th.js"></script>
+
+<body onload="checkLayout('.grid')">
+<div id="log"></div>
+<p>This test checks that margin is computed correctly for content-sized tracks when using different writing modes.</p>
Manuel Rego 2016/12/02 12:30:47 Nit: s/that margin/that grid items' margin/
jfernandez 2016/12/02 13:36:07 Done.
+
+<div style="position: relative">
+ <div class="grid fit-content itemsStart" data-expected-width="40" data-expected-height="140">
+ <div class="item verticalLR" data-offset-x="15" data-offset-y="10" data-expected-width="20" data-expected-height="20">X</div>
+ <div class="item verticalLR" data-offset-x="15" data-offset-y="45" data-expected-width="20" data-expected-height="20">X</div>
+ <div class="item verticalLR" data-offset-x="15" data-offset-y="80" data-expected-width="20" data-expected-height="20">X</div>
+ <div class="item verticalLR" data-offset-x="15" data-offset-y="115" data-expected-width="20" data-expected-height="20">X</div>
+ </div>
+</div>
+
+<br>
+
+<div style="position: relative">
+ <div class="grid row fit-content itemsStart" data-expected-width="160" data-expected-height="35">
+ <div class="item verticalLR" data-offset-x="15" data-offset-y="10" data-expected-width="20" data-expected-height="20">X</div>
+ <div class="item verticalLR" data-offset-x="55" data-offset-y="10" data-expected-width="20" data-expected-height="20">X</div>
+ <div class="item verticalLR" data-offset-x="95" data-offset-y="10" data-expected-width="20" data-expected-height="20">X</div>
+ <div class="item verticalLR" data-offset-x="135" data-offset-y="10" data-expected-width="20" data-expected-height="20">X</div>
+ </div>
+</div>
+
+<br>
+
+<div style="position: relative">
+ <div class="grid fit-content verticalLR itemsStart" data-expected-width="160" data-expected-height="35">
+ <div class="item horizontalTB" data-offset-x="15" data-offset-y="10" data-expected-width="20" data-expected-height="20">X</div>
+ <div class="item horizontalTB" data-offset-x="55" data-offset-y="10" data-expected-width="20" data-expected-height="20">X</div>
+ <div class="item horizontalTB" data-offset-x="95" data-offset-y="10" data-expected-width="20" data-expected-height="20">X</div>
+ <div class="item horizontalTB" data-offset-x="135" data-offset-y="10" data-expected-width="20" data-expected-height="20">X</div>
+ </div>
+</div>
+
+<br>
+
+<div style="position: relative">
+ <div class="grid row fit-content verticalLR itemsStart" data-expected-width="40" data-expected-height="140">
+ <div class="item horizontalTB" data-offset-x="15" data-offset-y="10" data-expected-width="20" data-expected-height="20">X</div>
+ <div class="item horizontalTB" data-offset-x="15" data-offset-y="45" data-expected-width="20" data-expected-height="20">X</div>
+ <div class="item horizontalTB" data-offset-x="15" data-offset-y="80" data-expected-width="20" data-expected-height="20">X</div>
+ <div class="item horizontalTB" data-offset-x="15" data-offset-y="115" data-expected-width="20" data-expected-height="20">X</div>
+ </div>
+</div>
+
+</body>
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698