Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-margins-and-orthogonal-flows.html

Issue 2543193002: [css-grid] Use child's marginLogicalWidth to compute content-sized track (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 <!DOCTYPE html>
2 <link href="resources/grid.css" rel="stylesheet">
3 <link href="resources/grid-alignment.css" rel="stylesheet">
4 <link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel ="stylesheet">
5 <style>
6 body { margin: 0; }
Manuel Rego 2016/12/02 12:30:47 I don't think you need this.
jfernandez 2016/12/02 13:36:07 Done.
7 .grid { font: 20px/1 Ahem; }
8 .row { grid-auto-flow: column; }
Manuel Rego 2016/12/02 12:30:47 Nit: This is already defined in grid.css: "gridAut
jfernandez 2016/12/02 13:36:07 Done.
9 .item { margin: 10px 5px 5px 15px; }
Manuel Rego 2016/12/02 12:30:47 Nit: Extra space "{ margin".
jfernandez 2016/12/02 13:36:06 Done.
10 </style>
11 <script src="../../resources/testharness.js"></script>
12 <script src="../../resources/testharnessreport.js"></script>
13 <script src="../../resources/check-layout-th.js"></script>
14
15 <body onload="checkLayout('.grid')">
16 <div id="log"></div>
17 <p>This test checks that margin is computed correctly for content-sized tracks w hen using different writing modes.</p>
Manuel Rego 2016/12/02 12:30:47 Nit: s/that margin/that grid items' margin/
jfernandez 2016/12/02 13:36:07 Done.
18
19 <div style="position: relative">
20 <div class="grid fit-content itemsStart" data-expected-width="40" data-expec ted-height="140">
21 <div class="item verticalLR" data-offset-x="15" data-offset-y="10" data -expected-width="20" data-expected-height="20">X</div>
22 <div class="item verticalLR" data-offset-x="15" data-offset-y="45" data -expected-width="20" data-expected-height="20">X</div>
23 <div class="item verticalLR" data-offset-x="15" data-offset-y="80" data -expected-width="20" data-expected-height="20">X</div>
24 <div class="item verticalLR" data-offset-x="15" data-offset-y="115" data -expected-width="20" data-expected-height="20">X</div>
25 </div>
26 </div>
27
28 <br>
29
30 <div style="position: relative">
31 <div class="grid row fit-content itemsStart" data-expected-width="160" data- expected-height="35">
32 <div class="item verticalLR" data-offset-x="15" data-offset-y="10" data -expected-width="20" data-expected-height="20">X</div>
33 <div class="item verticalLR" data-offset-x="55" data-offset-y="10" data -expected-width="20" data-expected-height="20">X</div>
34 <div class="item verticalLR" data-offset-x="95" data-offset-y="10" data -expected-width="20" data-expected-height="20">X</div>
35 <div class="item verticalLR" data-offset-x="135" data-offset-y="10" data -expected-width="20" data-expected-height="20">X</div>
36 </div>
37 </div>
38
39 <br>
40
41 <div style="position: relative">
42 <div class="grid fit-content verticalLR itemsStart" data-expected-width="160 " data-expected-height="35">
43 <div class="item horizontalTB" data-offset-x="15" data-offset-y="10" da ta-expected-width="20" data-expected-height="20">X</div>
44 <div class="item horizontalTB" data-offset-x="55" data-offset-y="10" da ta-expected-width="20" data-expected-height="20">X</div>
45 <div class="item horizontalTB" data-offset-x="95" data-offset-y="10" da ta-expected-width="20" data-expected-height="20">X</div>
46 <div class="item horizontalTB" data-offset-x="135" data-offset-y="10" da ta-expected-width="20" data-expected-height="20">X</div>
47 </div>
48 </div>
49
50 <br>
51
52 <div style="position: relative">
53 <div class="grid row fit-content verticalLR itemsStart" data-expected-width= "40" data-expected-height="140">
54 <div class="item horizontalTB" data-offset-x="15" data-offset-y="10" da ta-expected-width="20" data-expected-height="20">X</div>
55 <div class="item horizontalTB" data-offset-x="15" data-offset-y="45" da ta-expected-width="20" data-expected-height="20">X</div>
56 <div class="item horizontalTB" data-offset-x="15" data-offset-y="80" da ta-expected-width="20" data-expected-height="20">X</div>
57 <div class="item horizontalTB" data-offset-x="15" data-offset-y="115" da ta-expected-width="20" data-expected-height="20">X</div>
58 </div>
59 </div>
60
61 </body>
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698