Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2543133002: Fixing a problem where curtain mode connections were failing on Windows 8+ (Closed)

Created:
4 years ago by joedow
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fixing a problem where curtain mode connections were failing on Windows 8+ I tracked this down to a change I made where I added the uiAccess flag to the remoting_desktop binary (https://codereview.chromium.org/2370293002/). Adding this manifest flag causes CreateProcess to fail with STATUS_ELEVATION_REQUIRED when run in curtain mode. I suspect it has something to do with the process being started in the logon session. I am reverting this flag to unblock this scenario (M56 needs this fix) and will verify whether the flag is actually needed (it was originally added for parity with GYP builds but may not be necessary). BUG=666992 Review-Url: https://codereview.chromium.org/2521453005 Cr-Commit-Position: refs/heads/master@{#435272} (cherry picked from commit fdd9968f262f1fba0d9b2f3e0261226732e2ee67) Committed: https://chromium.googlesource.com/chromium/src/+/ffa8fec145e25ac6b34ee56c65d6b11eb9369c76

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/host/win/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
joedow
4 years ago (2016-12-02 02:51:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ffa8fec145e25ac6b34ee56c65d6b11eb9369c76.

Powered by Google App Engine
This is Rietveld 408576698