Fixing a problem where curtain mode connections were failing on Windows 8+

Fixing a problem where curtain mode connections were failing on Windows 8+

I tracked this down to a change I made where I added the uiAccess flag to
the remoting_desktop binary (https://codereview.chromium.org/2370293002/).
Adding this manifest flag causes CreateProcess to fail with
STATUS_ELEVATION_REQUIRED when run in curtain mode.  I suspect it has
something to do with the process being started in the logon session.

I am reverting this flag to unblock this scenario (M56 needs this fix) and
will verify whether the flag is actually needed (it was originally added for
parity with GYP builds but may not be necessary).

BUG=666992
Committed: https://crrev.com/fdd9968f262f1fba0d9b2f3e0261226732e2ee67
Cr-Commit-Position: refs/heads/master@{#435272}

[joedow, 2016-11-22 04:54:50]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 04:55:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 06:12:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 06:12:21]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-11-28 16:20:27]

joedow@chromium.org changed reviewers:
+ sergeyu@chromium.org

[joedow, 2016-11-28 16:20:27]

PTAL!

[Sergey Ulanov, 2016-11-28 20:41:11]

lgtm

[joedow, 2016-11-30 00:01:00]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-11-30 00:02:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 02:05:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 02:05:33]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[joedow, 2016-11-30 02:09:00]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-11-30 02:10:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 04:11:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 04:11:22]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[joedow, 2016-11-30 14:35:27]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-11-30 14:35:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 15:59:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480516527151240, "parent_rev":
"55e48af0f4fba19baba82f3aa03beab198a5356c", "commit_rev":
"f33939645c9bc46b74eb787ede87e2470639b166"}

[commit-bot: I haz the power, 2016-11-30 15:59:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-30 16:04:33]

Description was changed from

==========
Fixing a problem where curtain mode connections were failing on Windows 8+

I tracked this down to a change I made where I added the uiAccess flag to
the remoting_desktop binary (https://codereview.chromium.org/2370293002/).
Adding this manifest flag causes CreateProcess to fail with
STATUS_ELEVATION_REQUIRED when run in curtain mode.  I suspect it has
something to do with the process being started in the logon session.

I am reverting this flag to unblock this scenario (M56 needs this fix) and
will verify whether the flag is actually needed (it was originally added for
parity with GYP builds but may not be necessary).

BUG=666992
==========

to

==========
Fixing a problem where curtain mode connections were failing on Windows 8+

I tracked this down to a change I made where I added the uiAccess flag to
the remoting_desktop binary (https://codereview.chromium.org/2370293002/).
Adding this manifest flag causes CreateProcess to fail with
STATUS_ELEVATION_REQUIRED when run in curtain mode.  I suspect it has
something to do with the process being started in the logon session.

I am reverting this flag to unblock this scenario (M56 needs this fix) and
will verify whether the flag is actually needed (it was originally added for
parity with GYP builds but may not be necessary).

BUG=666992

Committed: https://crrev.com/fdd9968f262f1fba0d9b2f3e0261226732e2ee67
Cr-Commit-Position: refs/heads/master@{#435272}
==========

[commit-bot: I haz the power, 2016-11-30 16:04:34]

Patchset 1 (id:??) landed as
https://crrev.com/fdd9968f262f1fba0d9b2f3e0261226732e2ee67
Cr-Commit-Position: refs/heads/master@{#435272}