Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.h

Issue 2543123003: gpu, cmaa: improve |do_copy| condition logic (Closed)
Patch Set: use existing attachment->object_name() Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.h
diff --git a/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.h b/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.h
index 497b8c68d386e5ed47125895afa0c242a736bd60..f9bad673293257f54fde6df01267c1f06d731c19 100644
--- a/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.h
+++ b/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.h
@@ -13,6 +13,7 @@ namespace gles2 {
class CopyTextureCHROMIUMResourceManager;
class GLES2Decoder;
class Framebuffer;
+class TextureManager;
// This class encapsulates the resources required to implement the
// GL_INTEL_framebuffer_CMAA extension via shaders.
@@ -32,9 +33,10 @@ class GPU_EXPORT ApplyFramebufferAttachmentCMAAINTELResourceManager {
// Applies the algorithm to the color attachments of the currently bound draw
// framebuffer.
void ApplyFramebufferAttachmentCMAAINTEL(
- gles2::GLES2Decoder* decoder,
- gles2::Framebuffer* framebuffer,
- gles2::CopyTextureCHROMIUMResourceManager* copier);
+ GLES2Decoder* decoder,
+ Framebuffer* framebuffer,
+ CopyTextureCHROMIUMResourceManager* copier,
+ TextureManager* texture_manager);
Zhenyao Mo 2016/12/09 18:21:05 I prefer exposing texture_manager() to GLES2Decode
dshwang 2017/01/12 17:19:34 That's good idea, but currently this kind of metho
private:
// Applies the CMAA algorithm to a texture.

Powered by Google App Engine
This is Rietveld 408576698