gpu, cmaa: improve |do_copy| condition logic

gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_APPLY_FRAMEBUFFER_ATTACHMENT_CMAA_INTEL_H_
 #define GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_APPLY_FRAMEBUFFER_ATTACHMENT_CMAA_INTEL_H_
 
 #include "gpu/command_buffer/service/gl_utils.h"
 #include "gpu/gpu_export.h"
 
 namespace gpu {
 namespace gles2 {
 class CopyTextureCHROMIUMResourceManager;
 class GLES2Decoder;
 class Framebuffer;
+class TextureManager;
 
 // This class encapsulates the resources required to implement the
 // GL_INTEL_framebuffer_CMAA extension via shaders.
 //
 // The CMAA Conservative Morphological Anti-Aliasing) algorithm is applied to
 // all color attachments of the currently bound draw framebuffer.
 //
 // Reference GL_INTEL_framebuffer_CMAA for details.
 class GPU_EXPORT ApplyFramebufferAttachmentCMAAINTELResourceManager {
  public:
   ApplyFramebufferAttachmentCMAAINTELResourceManager();
   ~ApplyFramebufferAttachmentCMAAINTELResourceManager();
 
   void Initialize(gles2::GLES2Decoder* decoder);
   void Destroy();
 
   // Applies the algorithm to the color attachments of the currently bound draw
   // framebuffer.
   void ApplyFramebufferAttachmentCMAAINTEL(
-      gles2::GLES2Decoder* decoder,
-      gles2::Framebuffer* framebuffer,
-      gles2::CopyTextureCHROMIUMResourceManager* copier);
+      GLES2Decoder* decoder,
+      Framebuffer* framebuffer,
+      CopyTextureCHROMIUMResourceManager* copier,
+      TextureManager* texture_manager);

[Zhenyao Mo, 2016/12/09 18:21:05]

I prefer exposing texture_manager() to GLES2Decoder so we don't have to pass it
as an arg, but it's not a big deal.

[dshwang, 2017/01/12 17:19:34]

That's good idea, but currently this kind of method is exposed at
GLES2DecoderImpl, which is defined in cc file. Few managers are exposed at
GLES2Decoder, but all are for unittests. Let me keep consistency with existing
code.

 
  private:
   // Applies the CMAA algorithm to a texture.
   void ApplyCMAAEffectTexture(GLuint source_texture,
                               GLuint dest_texture,
                               bool do_copy);
 
   void OnSize(GLint width, GLint height);
   void ReleaseTextures();
 
@@ skipping 40 matching lines @@
   static const char cmaa_frag_s1_[];
   static const char cmaa_frag_s2_[];
 
   DISALLOW_COPY_AND_ASSIGN(ApplyFramebufferAttachmentCMAAINTELResourceManager);
 };
 
 }  // namespace gles2
 }  // namespace gpu
 
 #endif  // GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_APPLY_FRAMEBUFFER_ATTACHMENT_CMAA_INTEL_H_