Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: components/offline_pages/background/cleanup_task_factory.h

Issue 2543093002: Split the RequestPicker task into two separate tasks. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/cleanup_task_factory.h
diff --git a/components/offline_pages/background/cleanup_task_factory.h b/components/offline_pages/background/cleanup_task_factory.h
new file mode 100644
index 0000000000000000000000000000000000000000..14b5ca58b89a1f41e6c78994f7e0d24107d68795
--- /dev/null
+++ b/components/offline_pages/background/cleanup_task_factory.h
@@ -0,0 +1,45 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_CLEANUP_TASK_FACTORY_H_
+#define COMPONENTS_OFFLINE_PAGES_BACKGROUND_CLEANUP_TASK_FACTORY_H_
+
+#include <stdint.h>
+
+#include <set>
+
+#include "components/offline_pages/background/cleanup_task.h"
+
+namespace offline_pages {
+
+class OfflinerPolicy;
+class RequestCoordinatorEventLogger;
+class RequestNotifier;
+class RequestQueueStore;
+
+// TODO: Should I rename this since it now has two uses?
dougarnett 2016/12/02 17:20:26 Think just one at the moment
fgorski 2016/12/02 21:44:04 What do you mean by 2 uses?
Pete Williamson 2016/12/05 20:39:45 Oops, this is an old comment, I refactored so that
+class CleanupTaskFactory {
+ public:
+ CleanupTaskFactory(OfflinerPolicy* policy,
+ RequestNotifier* notifier,
+ RequestCoordinatorEventLogger* event_logger);
+
+ ~CleanupTaskFactory();
+
+ std::unique_ptr<CleanupTask> CreatePickerTask(RequestQueueStore* store);
dougarnett 2016/12/02 17:20:26 Remove this declaration, right?
fgorski 2016/12/02 21:44:04 +1
Pete Williamson 2016/12/05 20:39:45 Done.
+
+ std::unique_ptr<CleanupTask> CreateCleanupTask(RequestQueueStore* store);
+
+ private:
+ // Unowned pointer to the Policy
+ OfflinerPolicy* policy_;
+ // Unowned pointer to the notifier
+ RequestNotifier* notifier_;
+ // Unowned pointer to the EventLogger
+ RequestCoordinatorEventLogger* event_logger_;
+};
+
+} // namespace offline_pages
+
+#endif // COMPONENTS_OFFLINE_PAGES_BACKGROUND_CLEANUP_TASK_FACTORY_H_

Powered by Google App Engine
This is Rietveld 408576698