Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Side by Side Diff: components/offline_pages/background/cleanup_task_factory.h

Issue 2543093002: Split the RequestPicker task into two separate tasks. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_CLEANUP_TASK_FACTORY_H_
6 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_CLEANUP_TASK_FACTORY_H_
7
8 #include <stdint.h>
9
10 #include <set>
11
12 #include "components/offline_pages/background/cleanup_task.h"
13
14 namespace offline_pages {
15
16 class OfflinerPolicy;
17 class RequestCoordinatorEventLogger;
18 class RequestNotifier;
19 class RequestQueueStore;
20
21 // TODO: Should I rename this since it now has two uses?
dougarnett 2016/12/02 17:20:26 Think just one at the moment
fgorski 2016/12/02 21:44:04 What do you mean by 2 uses?
Pete Williamson 2016/12/05 20:39:45 Oops, this is an old comment, I refactored so that
22 class CleanupTaskFactory {
23 public:
24 CleanupTaskFactory(OfflinerPolicy* policy,
25 RequestNotifier* notifier,
26 RequestCoordinatorEventLogger* event_logger);
27
28 ~CleanupTaskFactory();
29
30 std::unique_ptr<CleanupTask> CreatePickerTask(RequestQueueStore* store);
dougarnett 2016/12/02 17:20:26 Remove this declaration, right?
fgorski 2016/12/02 21:44:04 +1
Pete Williamson 2016/12/05 20:39:45 Done.
31
32 std::unique_ptr<CleanupTask> CreateCleanupTask(RequestQueueStore* store);
33
34 private:
35 // Unowned pointer to the Policy
36 OfflinerPolicy* policy_;
37 // Unowned pointer to the notifier
38 RequestNotifier* notifier_;
39 // Unowned pointer to the EventLogger
40 RequestCoordinatorEventLogger* event_logger_;
41 };
42
43 } // namespace offline_pages
44
45 #endif // COMPONENTS_OFFLINE_PAGES_BACKGROUND_CLEANUP_TASK_FACTORY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698