Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2543073005: Make ManifestUpgradeDetectorTest use the intent version of WebApkInfo#create() (Closed)

Created:
4 years ago by pkotwicz
Modified:
4 years ago
Reviewers:
dominickn
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ManifestUpgradeDetectorTest use the intent version of WebApkInfo#create() - This makes the tests more integration-test-like. - This is a step towards merging ManifestUpgradeDetectorTest and WebApkUpdateManagerTest (See https://codereview.chromium.org/2460253002/) BUG=639536 Committed: https://crrev.com/78660e873fd72044bcbcd970fd7456453680b564 Cr-Commit-Position: refs/heads/master@{#436326}

Patch Set 1 : Merge branch 'master' into update_fail_refactor01 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -59 lines) Patch
M chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java View 10 chunks +61 lines, -59 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
pkotwicz
Dominick, can you please take a look?
4 years ago (2016-12-03 23:57:12 UTC) #4
dominickn
On 2016/12/03 23:57:12, pkotwicz wrote: > Dominick, can you please take a look? lgtm
4 years ago (2016-12-04 22:40:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543073005/20001
4 years ago (2016-12-05 16:51:05 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-05 17:03:01 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-05 17:05:01 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78660e873fd72044bcbcd970fd7456453680b564
Cr-Commit-Position: refs/heads/master@{#436326}

Powered by Google App Engine
This is Rietveld 408576698