Add texture swizzle back to command buffer.

Add texture swizzle back to command buffer.

If it's ES3 context, allow them. If it's WebGL2 context, disallow them.

BUG=669168
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/90dcedd24853cdca918845ba57a13d9856c8d24e
Cr-Commit-Position: refs/heads/master@{#435794}

[Zhenyao Mo, 2016-12-01 22:13:11]

Description was changed from

==========
Add texture swizzle back to command buffer.

If it's ES3 context, allow them. If it's WebGL2 context, disallow them.

BUG=669168
TEST=gpu_unittests
R=piman@chromium.org
==========

to

==========
Add texture swizzle back to command buffer.

If it's ES3 context, allow them. If it's WebGL2 context, disallow them.

BUG=669168
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-12-01 22:13:34]

Description was changed from

==========
Add texture swizzle back to command buffer.

If it's ES3 context, allow them. If it's WebGL2 context, disallow them.

BUG=669168
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add texture swizzle back to command buffer.

If it's ES3 context, allow them. If it's WebGL2 context, disallow them.

BUG=669168
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-12-01 22:13:44]

piman: PTAL

[Zhenyao Mo, 2016-12-01 22:13:49]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 22:14:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-12-01 22:44:32]

LGTM, thanks!

[Ken Russell (switch to Gerrit), 2016-12-01 22:46:26]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-12-01 22:46:27]

Thanks for putting this back in Mo.

https://codereview.chromium.org/2543033002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2543033002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:1499:
validators_.texture_parameter.AddValue(GL_TEXTURE_SWIZZLE_A);
What about an understanding of the valid values for these parameters?

https://codereview.chromium.org/2543033002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc (right):

https://codereview.chromium.org/2543033002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc:4723:
TEST_P(GLES3DecoderTest, TexSwizzleValid) {
A test is needed of passing an invalid swizzle value (i.e., something other than
GL_RED, GL_GREEN, GL_BLUE, or GL_ALPHA).

[Zhenyao Mo, 2016-12-01 22:47:51]

https://codereview.chromium.org/2543033002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2543033002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:1499:
validators_.texture_parameter.AddValue(GL_TEXTURE_SWIZZLE_A);
On 2016/12/01 22:46:27, Ken Russell wrote:
> What about an understanding of the valid values for these parameters?

It's already in place. I'll add a test for that.

[Zhenyao Mo, 2016-12-01 22:52:51]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[Zhenyao Mo, 2016-12-01 22:53:08]

kbr: test case added. Please take another look.

[commit-bot: I haz the power, 2016-12-01 22:53:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 00:03:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 00:03:34]

Dry run: This issue passed the CQ dry run.

[Ken Russell (switch to Gerrit), 2016-12-02 00:31:14]

LGTM

Apologies, I hadn't realized the TextureSwizzle enum set in
build_gles2_cmd_buffer.py was already wired up, but thanks for adding the
negative test.

[Zhenyao Mo, 2016-12-02 00:31:49]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-12-02 00:31:50]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2543033002/#ps20001
(title: "add swizzle value negative test")

[commit-bot: I haz the power, 2016-12-02 00:33:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 00:38:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480638709856070,
"parent_rev": "c9a0d7e36be6f36df45381bae7697e28c3ebe0ba", "commit_rev":
"96835b14257a936a3e211fa6dd8c1ed01f5c9340"}

[commit-bot: I haz the power, 2016-12-02 00:38:38]

Description was changed from

==========
Add texture swizzle back to command buffer.

If it's ES3 context, allow them. If it's WebGL2 context, disallow them.

BUG=669168
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add texture swizzle back to command buffer.

If it's ES3 context, allow them. If it's WebGL2 context, disallow them.

BUG=669168
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-12-02 00:38:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-02 00:42:43]

Description was changed from

==========
Add texture swizzle back to command buffer.

If it's ES3 context, allow them. If it's WebGL2 context, disallow them.

BUG=669168
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add texture swizzle back to command buffer.

If it's ES3 context, allow them. If it's WebGL2 context, disallow them.

BUG=669168
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/90dcedd24853cdca918845ba57a13d9856c8d24e
Cr-Commit-Position: refs/heads/master@{#435794}
==========

[commit-bot: I haz the power, 2016-12-02 00:42:44]

Patchset 2 (id:??) landed as
https://crrev.com/90dcedd24853cdca918845ba57a13d9856c8d24e
Cr-Commit-Position: refs/heads/master@{#435794}