Fix TestBrowserThread destruction order in Android history tests.

Fix TestBrowserThread destruction order in Android history tests.

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after it
was.

BUG=653916
Committed: https://crrev.com/683111e5efbf225875eadf59804494611e9257d9
Cr-Commit-Position: refs/heads/master@{#435995}

[gab, 2016-12-01 23:32:23]

gab@chromium.org changed reviewers:
+ mattm@chromium.org, sdefresne@chromium.org

[gab, 2016-12-01 23:32:24]

@sdefresne for history/

@mattm for safe_browsing/ (I don't understand how it passed before... it's
clearly using a MessageLoopForIO::current() mid-test and I don't see how
https://codereview.chromium.org/2464233002 changes conditions here but it
somehow does and forces this to be properly labeled..?!)

[gab, 2016-12-01 23:32:29]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 23:33:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 23:58:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 23:58:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mattm, 2016-12-01 23:58:40]

On 2016/12/01 23:32:24, gab wrote:
> @sdefresne for history/
> 
> @mattm for safe_browsing/ (I don't understand how it passed before... it's
> clearly using a MessageLoopForIO::current() mid-test and I don't see how
> https://codereview.chromium.org/2464233002 changes conditions here but it
> somehow does and forces this to be properly labeled..?!)

where is the MessageLoopForIO::current() happening?

[gab, 2016-12-02 00:02:59]

On 2016/12/01 23:58:40, mattm wrote:
> On 2016/12/01 23:32:24, gab wrote:
> > @sdefresne for history/
> > 
> > @mattm for safe_browsing/ (I don't understand how it passed before... it's
> > clearly using a MessageLoopForIO::current() mid-test and I don't see how
> > https://codereview.chromium.org/2464233002 changes conditions here but it
> > somehow does and forces this to be properly labeled..?!)
> 
> where is the MessageLoopForIO::current() happening?

On Android only in handling some asynchronous net stuff (didn't track
FROM_HERE..). And it looks like the converse (this CL) is making non-Android
bots unhappy.. hmmm...

[gab, 2016-12-02 16:00:22]

Description was changed from

==========
Fix TestBrowserThread destruction order in Android tests.

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after it
was.

BUG=653916
==========

to

==========
Fix TestBrowserThread destruction order in Android history tests.

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after it
was.

BUG=653916
==========

[gab, 2016-12-02 16:00:22]

gab@chromium.org changed reviewers:
- mattm@chromium.org

[gab, 2016-12-02 16:00:26]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 16:00:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-12-02 16:01:10]

On 2016/12/02 00:02:59, gab wrote:
> On 2016/12/01 23:58:40, mattm wrote:
> > On 2016/12/01 23:32:24, gab wrote:
> > > @sdefresne for history/

ping sdefresne, thanks :-)

> > > 
> > > @mattm for safe_browsing/ (I don't understand how it passed before... it's
> > > clearly using a MessageLoopForIO::current() mid-test and I don't see how
> > > https://codereview.chromium.org/2464233002 changes conditions here but it
> > > somehow does and forces this to be properly labeled..?!)
> > 
> > where is the MessageLoopForIO::current() happening?
> 
> On Android only in handling some asynchronous net stuff (didn't track
> FROM_HERE..). And it looks like the converse (this CL) is making non-Android
> bots unhappy.. hmmm...

Removed safe_browsing changes from this CL while I dig deeper...

[commit-bot: I haz the power, 2016-12-02 16:21:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 16:21:53]

Dry run: This issue passed the CQ dry run.

[gab, 2016-12-02 19:13:50]

gab@chromium.org changed reviewers:
+ sky@chromium.org

[gab, 2016-12-02 19:13:50]

@sky: looks like sdefresne is off to the weekend on his side of the world, mind
taking a quick look?

[sky, 2016-12-02 19:15:25]

LGTM

[gab, 2016-12-02 19:30:50]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-12-02 19:31:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 19:38:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480707050610890,
"parent_rev": "dd48556559848b95f417d1370d21f8c9a547ea38", "commit_rev":
"d317b8cca1ed1701429fc74150dcabd5d483655c"}

[commit-bot: I haz the power, 2016-12-02 19:38:53]

Description was changed from

==========
Fix TestBrowserThread destruction order in Android history tests.

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after it
was.

BUG=653916
==========

to

==========
Fix TestBrowserThread destruction order in Android history tests.

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after it
was.

BUG=653916
==========

[commit-bot: I haz the power, 2016-12-02 19:38:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-02 19:40:56]

Description was changed from

==========
Fix TestBrowserThread destruction order in Android history tests.

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after it
was.

BUG=653916
==========

to

==========
Fix TestBrowserThread destruction order in Android history tests.

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after it
was.

BUG=653916

Committed: https://crrev.com/683111e5efbf225875eadf59804494611e9257d9
Cr-Commit-Position: refs/heads/master@{#435995}
==========

[commit-bot: I haz the power, 2016-12-02 19:40:57]

Patchset 2 (id:??) landed as
https://crrev.com/683111e5efbf225875eadf59804494611e9257d9
Cr-Commit-Position: refs/heads/master@{#435995}

[sdefresne, 2016-12-05 15:08:57]

lgtm