Issue 25932002: Revert "GYP variable v8_optimized_debug should be overridable by GYP_DEFINES"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25932002: Revert "GYP variable v8_optimized_debug should be overridable by GYP_DEFINES" (Closed)

Created:
7 years, 2 months ago by Dirk Pranke

Modified:
7 years, 2 months ago

Reviewers:
rafaelw, Jakob Kummerow

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "GYP variable v8_optimized_debug should be overridable by GYP_DEFINES" This reverts r226772; it looks like this broke the default behavior when the variable was not set in GYP_DEFINES. TBR=jkummerow@chromium.org, rafaelw@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226843

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	build/common.gypi	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

Committed patchset #1 manually as r226843 (presubmit successful).

7 years, 2 months ago (2013-10-03 20:58:35 UTC) #3

Dirk Pranke

The original patch was found in https://codereview.chromium.org/25430003/ . You can see the regression in http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=html5lib%2Fgenerated%2Frun-tests2-data.html ...

7 years, 2 months ago (2013-10-03 20:59:02 UTC) #4

Message was sent while issue was closed.

LGTM :-/

Expand Messages | Collapse Messages