Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2542993002: Refactoring: Make QuicSignedServerConfig contain a QuicCryptoProof (Closed)

Created:
4 years ago by Ryan Hamilton
Modified:
4 years ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring: Make QuicSignedServerConfig contain a QuicCryptoProof The QuicSignedServerConfig had all the fields that exist in QuicCryptoProof and they were simply copied over. That makes no sense - instead, this CL makes QuicCryptoProof one of the fields in QuicSignedServerConfig. Refactoring of the fields in QuicSignedServerConfig (no functional change) Merge internal change: 139827298 BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -32 lines) Patch
M net/quic/core/crypto/quic_crypto_server_config.h View 2 chunks +2 lines, -11 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 7 chunks +14 lines, -20 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2550453002 Patch 1

Dependent Patchsets:

Issue 2544063002 Patch 1

Messages

Total messages: 3 (1 generated)
Ryan Hamilton
4 years ago (2016-12-01 21:14:59 UTC) #2
Zhongyi Shi
4 years ago (2016-12-01 22:17:43 UTC) #3 
lgtm

Powered by Google App Engine
This is Rietveld 408576698