Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: net/quic/core/crypto/quic_crypto_server_config.h

Issue 2542993002: Refactoring: Make QuicSignedServerConfig contain a QuicCryptoProof (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/core/crypto/quic_crypto_server_config.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/crypto/quic_crypto_server_config.h
diff --git a/net/quic/core/crypto/quic_crypto_server_config.h b/net/quic/core/crypto/quic_crypto_server_config.h
index 24b476ce645ccca9a26fc4c448d64f6af8055252..444102e715c2efefe16c4106c17f72ab6285a445 100644
--- a/net/quic/core/crypto/quic_crypto_server_config.h
+++ b/net/quic/core/crypto/quic_crypto_server_config.h
@@ -26,6 +26,7 @@
#include "net/quic/core/crypto/crypto_secret_boxer.h"
#include "net/quic/core/crypto/proof_source.h"
#include "net/quic/core/crypto/quic_compressed_certs_cache.h"
+#include "net/quic/core/crypto/quic_crypto_proof.h"
#include "net/quic/core/proto/cached_network_parameters.pb.h"
#include "net/quic/core/proto/source_address_token.pb.h"
#include "net/quic/core/quic_time.h"
@@ -788,22 +789,12 @@ struct NET_EXPORT_PRIVATE QuicSignedServerConfig
: public base::RefCounted<QuicSignedServerConfig> {
QuicSignedServerConfig();
- // TODO(eranm): Have a QuicCryptoProof field instead of signature, cert_sct.
- std::string signature;
+ QuicCryptoProof proof;
scoped_refptr<ProofSource::Chain> chain;
- std::string cert_sct;
// The server config that is used for this proof (and the rest of the
// request).
scoped_refptr<QuicCryptoServerConfig::Config> config;
std::string primary_scid;
- // Indication whether the Expect-CT header should be sent on the session
- // this proof relates to (for background, see
- // https://www.ietf.org/id/draft-stark-expect-ct-00.txt).
- // NOTE: This field is intentionally independent from the |cert_sct| one
- // and can be true even if |cert_sct| is empty.
- // The goal of the Expect-CT header is uncover cases where valid SCTs are
- // expected to be served, but aren't.
- bool send_expect_ct_header;
private:
friend class base::RefCounted<QuicSignedServerConfig>;
« no previous file with comments | « no previous file | net/quic/core/crypto/quic_crypto_server_config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698