Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2542903002: device: Cleanup class/struct forward declarations (Closed)

Created:
4 years ago by jbriance
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, shalamov, chromium-reviews, darin (slow to review), feature-vr-reviews_chromium.org, mac-reviews_chromium.org, Mikhail, ortuno+watch_chromium.org, qsr+mojo_chromium.org, scheib+watch_chromium.org, viettrungluu+watch_chromium.org, wanming.lin, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

device: Cleanup class/struct forward declarations Remove useless class and struct forward declarations, and add missing ones in device header files. BUG=662195 Committed: https://crrev.com/9f4dfb5d16885bf0189cdf21775a8095d0defa02 Cr-Commit-Position: refs/heads/master@{#435711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -84 lines) Patch
M device/bluetooth/bluetooth_adapter.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_adapter_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_device.h View 1 chunk +0 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_characteristic.h View 1 chunk +0 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_device_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_descriptor_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_socket.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/bluez/bluetooth_gatt_descriptor_bluez.h View 1 chunk +0 lines, -2 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_local_gatt_service_bluez.h View 1 chunk +0 lines, -7 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/bluez/bluetooth_service_record_bluez.h View 1 chunk +0 lines, -4 lines 0 comments Download
M device/bluetooth/dbus/bluez_dbus_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_application_service_provider.h View 1 chunk +0 lines, -2 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_android.h View 1 chunk +0 lines, -2 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/gamepad/gamepad_test_helpers.h View 1 chunk +0 lines, -2 lines 0 comments Download
M device/generic_sensor/platform_sensor_ambient_light_mac.h View 1 chunk +0 lines, -4 lines 0 comments Download
M device/generic_sensor/platform_sensor_android.h View 1 chunk +0 lines, -4 lines 0 comments Download
M device/hid/hid_service_linux.h View 1 chunk +0 lines, -2 lines 0 comments Download
M device/hid/hid_service_mac.h View 1 chunk +0 lines, -2 lines 0 comments Download
M device/hid/hid_service_win.h View 1 chunk +0 lines, -6 lines 0 comments Download
M device/udev_linux/udev_linux.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/usb/mojo/device_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M device/usb/mojo/device_manager_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M device/usb/usb_device_handle_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/usb/usb_device_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M device/usb/usb_device_linux.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/usb/usb_service_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/usb/usb_service_linux.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/vr/android/gvr/gvr_device_provider.h View 1 chunk +0 lines, -2 lines 0 comments Download
M device/vr/vr_device.h View 1 chunk +0 lines, -8 lines 0 comments Download
M device/vr/vr_device_provider.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
jbriance
4 years ago (2016-12-01 13:20:39 UTC) #2
Reilly Grant (use Gerrit)
lgtm
4 years ago (2016-12-01 14:23:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542903002/1
4 years ago (2016-12-01 14:25:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/345910)
4 years ago (2016-12-01 16:24:37 UTC) #7
Ken Rockot(use gerrit already)
lgtm
4 years ago (2016-12-01 17:57:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542903002/1
4 years ago (2016-12-01 19:59:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 21:08:29 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-01 21:11:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f4dfb5d16885bf0189cdf21775a8095d0defa02
Cr-Commit-Position: refs/heads/master@{#435711}

Powered by Google App Engine
This is Rietveld 408576698