Create summary files in MockSdk classes

Create summary files in MockSdk classes

Committed: https://github.com/dart-lang/sdk/commit/e17e359faad7a55f51d81a8ab0810121609e8f3c

[Brian Wilkerson, 2016-12-01 22:27:30]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2016-12-01 22:27:31]

This is preliminary support required to get the test for lints being generated
using AnalysisDriver to work.

[scheglov, 2016-12-02 01:15:53]

Is it expensive to compute summary bundle every time when we create a new
MockSdk instance? I wonder if using an actual FolderBasedDartSdk with enabled
summaries might be faster now.

https://codereview.chromium.org/2542853003/diff/1/pkg/analysis_server/test/mo...
File pkg/analysis_server/test/mock_sdk.dart (right):

https://codereview.chromium.org/2542853003/diff/1/pkg/analysis_server/test/mo...
pkg/analysis_server/test/mock_sdk.dart:351: _bundle = new
PackageBundle.fromBuffer(_computeLinkedBundleBytes());
If we already have these bytes in the file system, it would be cheaper to read
them than to build again.

https://codereview.chromium.org/2542853003/diff/1/pkg/analyzer/test/src/conte...
File pkg/analyzer/test/src/context/mock_sdk.dart (right):

https://codereview.chromium.org/2542853003/diff/1/pkg/analyzer/test/src/conte...
pkg/analyzer/test/src/context/mock_sdk.dart:475: * Compute the bytes in the
linked bundle associated with this SDK.
"in the" -> "of the"?

[Brian Wilkerson, 2016-12-02 15:32:04]

https://codereview.chromium.org/2542853003/diff/1/pkg/analysis_server/test/mo...
File pkg/analysis_server/test/mock_sdk.dart (right):

https://codereview.chromium.org/2542853003/diff/1/pkg/analysis_server/test/mo...
pkg/analysis_server/test/mock_sdk.dart:351: _bundle = new
PackageBundle.fromBuffer(_computeLinkedBundleBytes());
Probably so, but when I tried to use the stored bytes one of the tests started
failing (PubSummaryManagerTest | test_getLinkedBundles_cached_differentSdk).
Therefore, I'm going to leave the optimization to a later CL.

https://codereview.chromium.org/2542853003/diff/1/pkg/analyzer/test/src/conte...
File pkg/analyzer/test/src/context/mock_sdk.dart (right):

https://codereview.chromium.org/2542853003/diff/1/pkg/analyzer/test/src/conte...
pkg/analyzer/test/src/context/mock_sdk.dart:475: * Compute the bytes in the
linked bundle associated with this SDK.
Done

[Brian Wilkerson, 2016-12-02 15:32:39]

Description was changed from

==========
Create summary files in MockSdk classes
==========

to

==========
Create summary files in MockSdk classes

Committed:
https://github.com/dart-lang/sdk/commit/e17e359faad7a55f51d81a8ab0810121609e8f3c
==========

[Brian Wilkerson, 2016-12-02 15:32:40]

Committed patchset #1 (id:1) manually as
e17e359faad7a55f51d81a8ab0810121609e8f3c (presubmit successful).

[scheglov, 2016-12-02 16:49:03]

Analysis Server tests time went up from 36 to 56 seconds :-(