Create summary files in MockSdk classes

pkg/analysis_server/test/mock_sdk.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library testing.mock_sdk;
 
 import 'package:analyzer/file_system/file_system.dart' as resource;
 import 'package:analyzer/file_system/memory_file_system.dart' as resource;
 import 'package:analyzer/src/context/context.dart';
 import 'package:analyzer/src/generated/engine.dart';
@@ skipping 256 matching lines @@
   /**
    * The cached linked bundle of the SDK.
    */
   PackageBundle _bundle;
 
   MockSdk({resource.ResourceProvider resourceProvider})
       : provider = resourceProvider ?? new resource.MemoryResourceProvider() {
     LIBRARIES.forEach((SdkLibrary library) {
       provider.newFile(library.path, (library as MockSdkLibrary).content);
     });
-    provider.newFile('/lib/_internal/sdk_library_metadata/lib/libraries.dart',
+    provider.newFile(
+        provider.convertPath(
+            '/lib/_internal/sdk_library_metadata/lib/libraries.dart'),
         librariesContent);
+    List<int> bytes = _computeLinkedBundleBytes();
+    provider.newFileWithBytes(
+        provider.convertPath('/lib/_internal/spec.sum'), bytes);
+    provider.newFileWithBytes(
+        provider.convertPath('/lib/_internal/strong.sum'), bytes);
   }
 
   @override
   AnalysisContext get context {
     if (_analysisContext == null) {
       _analysisContext = new SdkAnalysisContext(null);
       SourceFactory factory = new SourceFactory([new DartUriResolver(this)]);
       _analysisContext.sourceFactory = factory;
     }
     return _analysisContext;
@@ skipping 45 matching lines @@
           return null;
         }
       }
     }
     return null;
   }
 
   @override
   PackageBundle getLinkedBundle() {
     if (_bundle == null) {
-      List<Source> librarySources = sdkLibraries
-          .map((SdkLibrary library) => mapDartUri(library.shortName))
-          .toList();
-      List<int> bytes = new SummaryBuilder(
-              librarySources, context, context.analysisOptions.strongMode)
-          .build();
-      _bundle = new PackageBundle.fromBuffer(bytes);
+      _bundle = new PackageBundle.fromBuffer(_computeLinkedBundleBytes());

[scheglov, 2016/12/02 01:15:52]

If we already have these bytes in the file system, it would be cheaper to read
them than to build again.

[Brian Wilkerson, 2016/12/02 15:32:04]

Probably so, but when I tried to use the stored bytes one of the tests started
failing (PubSummaryManagerTest | test_getLinkedBundles_cached_differentSdk).
Therefore, I'm going to leave the optimization to a later CL.

     }
     return _bundle;
   }
 
   @override
   SdkLibrary getSdkLibrary(String dartUri) {
     // getSdkLibrary() is only used to determine whether a library is internal
     // to the SDK.  The mock SDK doesn't have any internals, so it's safe to
     // return null.
     return null;
@@ skipping 15 matching lines @@
     if (path != null) {
       resource.File file = provider.getResource(path);
       Uri uri = new Uri(scheme: 'dart', path: dartUri.substring(5));
       return file.createSource(uri);
     }
 
     // If we reach here then we tried to use a dartUri that's not in the
     // table above.
     return null;
   }
+
+  /**
+   * Compute the bytes in the linked bundle associated with this SDK.
+   */
+  List<int> _computeLinkedBundleBytes() {
+    List<Source> librarySources = sdkLibraries
+        .map((SdkLibrary library) => mapDartUri(library.shortName))
+        .toList();
+    return new SummaryBuilder(
+            librarySources, context, context.analysisOptions.strongMode)
+        .build();
+  }
 }
 
 class MockSdkLibrary implements SdkLibrary {
   final String shortName;
   final String path;
   final String content;
 
   const MockSdkLibrary(this.shortName, this.path, this.content);
 
   @override
@@ skipping 15 matching lines @@
   bool get isShared => throw unimplemented;
 
   @override
   bool get isVmLibrary => throw unimplemented;
 
   UnimplementedError get unimplemented => new UnimplementedError();
 
   @override
   List<String> getPatches(int platform) => const <String>[];
 }