UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function wil…

UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog".

UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in of one profile when the force-sign-in is disabled. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled.

Theoretically, this function can be called multiple times in one sign-in process. However, the fact is, once it's called by the second time, the javascript message will be sent to the "sync confirm dialog" but not the "sign-in dialog" which will close the "sync confirm dialog" automatically and causes other issue.s

The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not.

BUG=667227
Review-Url: https://codereview.chromium.org/2519123003
Cr-Commit-Position: refs/heads/master@{#434287}
(cherry picked from commit ff9fc46a4fdfb7c2975c867d8459e3cebe2e32fb)

Committed: https://chromium.googlesource.com/chromium/src/+/fc68fea1f07157b6ef761f348a3daae2e3ed7b2b

[Patrick Monette, 2016-11-30 23:49:08]

Description was changed from

==========
UnlockProfileAndHideLoginUI() will be called once the sign in is almost
finished. This function will unlock the profile, hide the UserManager and send
the message to javascript to close the "sign-in dialog".

UnlockProfileAndHideLoginUI() will be called in two places. The first one is for
the second sign-in of one profile when the force-sign-in is disabled. The second
one is after the OnClientOAuthSuccess when the force-sign-in is enabled.

Theoretically, this function can be called multiple times in one sign-in
process. However, the fact is, once it's called by the second time, the
javascript message will be sent to the "sync confirm dialog" but not the
"sign-in dialog" which will close the "sync confirm dialog" automatically and
causes other issue.s

The quick fix here is making sure that the function will be called at most once
no matter the force-sign-in is enabled or not.

BUG=667227

Review-Url: https://codereview.chromium.org/2519123003
Cr-Commit-Position: refs/heads/master@{#434287}
(cherry picked from commit ff9fc46a4fdfb7c2975c867d8459e3cebe2e32fb)
==========

to

==========
UnlockProfileAndHideLoginUI() will be called once the sign in is almost
finished. This function will unlock the profile, hide the UserManager and send
the message to javascript to close the "sign-in dialog".

UnlockProfileAndHideLoginUI() will be called in two places. The first one is for
the second sign-in of one profile when the force-sign-in is disabled. The second
one is after the OnClientOAuthSuccess when the force-sign-in is enabled.

Theoretically, this function can be called multiple times in one sign-in
process. However, the fact is, once it's called by the second time, the
javascript message will be sent to the "sync confirm dialog" but not the
"sign-in dialog" which will close the "sync confirm dialog" automatically and
causes other issue.s

The quick fix here is making sure that the function will be called at most once
no matter the force-sign-in is enabled or not.

BUG=667227

Review-Url: https://codereview.chromium.org/2519123003
Cr-Commit-Position: refs/heads/master@{#434287}
(cherry picked from commit ff9fc46a4fdfb7c2975c867d8459e3cebe2e32fb)

Committed:
https://chromium.googlesource.com/chromium/src/+/fc68fea1f07157b6ef761f348a3d...
==========

[Patrick Monette, 2016-11-30 23:49:09]

Committed patchset #1 (id:1) manually as
fc68fea1f07157b6ef761f348a3daae2e3ed7b2b.