Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2519123003:
Fix issue that closes sync confirm window after second sign-in in one profile. (Closed)
DescriptionUnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog".
UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in of one profile when the force-sign-in is disabled. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled.
Theoretically, this function can be called multiple times in one sign-in process. However, the fact is, once it's called by the second time, the javascript message will be sent to the "sync confirm dialog" but not the "sign-in dialog" which will close the "sync confirm dialog" automatically and causes other issue.s
The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not.
BUG=667227
Committed: https://crrev.com/ff9fc46a4fdfb7c2975c867d8459e3cebe2e32fb
Cr-Commit-Position: refs/heads/master@{#434287}
Patch Set 1 #
Messages
Total messages: 24 (16 generated)
The CQ bit was checked by zmin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Hi anthonyvd@, Can you please review the CL please? Owen
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
anthonyvd@chromium.org changed reviewers: + anthonyvd@chromium.org
Can you expand the description to explain why this fixes the issue? I was under the impression that this bug was independent of ForceSignin being enabled. Is that not the case? Basically I'm trying to figure out if this is a temporary band-aid or if this fixes all the possible repro cases. +Mihai since I believe one of those bugs is assigned to you. Thanks!
+Mihai for real now.
Description was changed from ========== Fix issue that closes sync confirm window after second sign-in in one profile. BUG=664410 BUG=667227 ========== to ========== UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog". UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in for the same profile when the force-sign-in is DISABLED. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled. Theoretically, this function can be called multiple times in one sign-in process. However, once it's called by the second time, the javascript message will be sent to "sync confirm dialog" but not the "sign-in dialog" which causes some other issues. The quick fix here is make sure the function will be called only once. BUG=667227 ==========
Description was changed from ========== UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog". UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in for the same profile when the force-sign-in is DISABLED. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled. Theoretically, this function can be called multiple times in one sign-in process. However, once it's called by the second time, the javascript message will be sent to "sync confirm dialog" but not the "sign-in dialog" which causes some other issues. The quick fix here is make sure the function will be called only once. BUG=667227 ========== to ========== UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog". UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in for the same profile when the force-sign-in is DISABLED. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled. Theoretically, this function can be called multiple times in one sign-in process. However, once it's called by the second time, the javascript message will be sent to "sync confirm dialog" but not the "sign-in dialog" which causes some other issues. The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not. BUG=667227 ==========
Description was changed from ========== UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog". UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in for the same profile when the force-sign-in is DISABLED. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled. Theoretically, this function can be called multiple times in one sign-in process. However, once it's called by the second time, the javascript message will be sent to "sync confirm dialog" but not the "sign-in dialog" which causes some other issues. The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not. BUG=667227 ========== to ========== UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog". UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in of one profile when the force-sign-in is DISABLED. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled. Theoretically, this function can be called multiple times in one sign-in process. However, once it's called by the second time, the javascript message will be sent to "sync confirm dialog" but not the "sign-in dialog" which causes some other issues. The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not. BUG=667227 ==========
Description was changed from ========== UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog". UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in of one profile when the force-sign-in is DISABLED. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled. Theoretically, this function can be called multiple times in one sign-in process. However, once it's called by the second time, the javascript message will be sent to "sync confirm dialog" but not the "sign-in dialog" which causes some other issues. The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not. BUG=667227 ========== to ========== UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog". UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in of one profile when the force-sign-in is disabled. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled. Theoretically, this function can be called multiple times in one sign-in process. However, once it's called by the second time, the javascript message will be sent to "sync confirm dialog" but not the "sign-in dialog" which causes some other issues. The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not. BUG=667227 ==========
Description was changed from ========== UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog". UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in of one profile when the force-sign-in is disabled. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled. Theoretically, this function can be called multiple times in one sign-in process. However, once it's called by the second time, the javascript message will be sent to "sync confirm dialog" but not the "sign-in dialog" which causes some other issues. The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not. BUG=667227 ========== to ========== UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog". UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in of one profile when the force-sign-in is disabled. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled. Theoretically, this function can be called multiple times in one sign-in process. However, the fact is, once it's called by the second time, the javascript message will be sent to "sync confirm dialog" but not the "sign-in dialog" which causes some other issues. The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not. BUG=667227 ==========
Description was changed from ========== UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog". UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in of one profile when the force-sign-in is disabled. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled. Theoretically, this function can be called multiple times in one sign-in process. However, the fact is, once it's called by the second time, the javascript message will be sent to "sync confirm dialog" but not the "sign-in dialog" which causes some other issues. The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not. BUG=667227 ========== to ========== UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog". UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in of one profile when the force-sign-in is disabled. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled. Theoretically, this function can be called multiple times in one sign-in process. However, the fact is, once it's called by the second time, the javascript message will be sent to the "sync confirm dialog" but not the "sign-in dialog" which causes some other issues. The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not. BUG=667227 ==========
Description was changed from ========== UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog". UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in of one profile when the force-sign-in is disabled. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled. Theoretically, this function can be called multiple times in one sign-in process. However, the fact is, once it's called by the second time, the javascript message will be sent to the "sync confirm dialog" but not the "sign-in dialog" which causes some other issues. The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not. BUG=667227 ========== to ========== UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog". UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in of one profile when the force-sign-in is disabled. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled. Theoretically, this function can be called multiple times in one sign-in process. However, the fact is, once it's called by the second time, the javascript message will be sent to the "sync confirm dialog" but not the "sign-in dialog" which will close the "sync confirm dialog" automatically and causes other issue.s The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not. BUG=667227 ==========
On 2016/11/22 19:52:52, anthonyvd wrote: > +Mihai for real now. Description updated.
lgtm
The CQ bit was checked by zmin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1479935046705730, "parent_rev":
"9feae9afda7fa2387afdf8853a69274493d31666", "commit_rev":
"f33834de42c72d1b83143dfcab5fa572226ec82c"}
Message was sent while issue was closed.
Description was changed from ========== UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog". UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in of one profile when the force-sign-in is disabled. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled. Theoretically, this function can be called multiple times in one sign-in process. However, the fact is, once it's called by the second time, the javascript message will be sent to the "sync confirm dialog" but not the "sign-in dialog" which will close the "sync confirm dialog" automatically and causes other issue.s The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not. BUG=667227 ========== to ========== UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog". UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in of one profile when the force-sign-in is disabled. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled. Theoretically, this function can be called multiple times in one sign-in process. However, the fact is, once it's called by the second time, the javascript message will be sent to the "sync confirm dialog" but not the "sign-in dialog" which will close the "sync confirm dialog" automatically and causes other issue.s The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not. BUG=667227 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog". UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in of one profile when the force-sign-in is disabled. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled. Theoretically, this function can be called multiple times in one sign-in process. However, the fact is, once it's called by the second time, the javascript message will be sent to the "sync confirm dialog" but not the "sign-in dialog" which will close the "sync confirm dialog" automatically and causes other issue.s The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not. BUG=667227 ========== to ========== UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog". UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in of one profile when the force-sign-in is disabled. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled. Theoretically, this function can be called multiple times in one sign-in process. However, the fact is, once it's called by the second time, the javascript message will be sent to the "sync confirm dialog" but not the "sign-in dialog" which will close the "sync confirm dialog" automatically and causes other issue.s The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not. BUG=667227 Committed: https://crrev.com/ff9fc46a4fdfb7c2975c867d8459e3cebe2e32fb Cr-Commit-Position: refs/heads/master@{#434287} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ff9fc46a4fdfb7c2975c867d8459e3cebe2e32fb Cr-Commit-Position: refs/heads/master@{#434287} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
