Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2542753002: Revert "Transition analyzer and analysis_server to new astFactory; remove old AST factory methods." (Closed)

Created:
4 years ago by vsm
Modified:
4 years ago
Reviewers:
Paul Berry
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Transition analyzer and analysis_server to new astFactory; remove old AST factory methods." This reverts commit 1d028eed8dfa00ac9d4ff685e61b01e6909dbeb4. This was breaking DDC. TBR=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/b8d3758dcd0f2150211ec0f20f28d1246782b4e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2208 lines, -1102 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/label_contributor.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analyzer/CHANGELOG.md View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/dart/ast/ast.dart View 112 chunks +1239 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 107 chunks +343 lines, -371 lines 0 comments Download
M pkg/analyzer/lib/src/dart/constant/evaluation.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 178 chunks +286 lines, -320 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/ast_test_factory.dart View 69 chunks +156 lines, -170 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/analyzer/test/dart/ast/ast_test.dart View 31 chunks +71 lines, -110 lines 0 comments Download
M pkg/analyzer/test/dart/element/builder_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analyzer/test/generated/element_resolver_test.dart View 4 chunks +3 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 15 chunks +25 lines, -38 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 24 chunks +47 lines, -28 lines 0 comments Download
M pkg/analyzer/test/src/dart/ast/utilities_test.dart View 16 chunks +19 lines, -20 lines 0 comments Download
M pkg/analyzer/test/src/dart/constant/utilities_test.dart View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
vsm
Committed patchset #1 (id:1) manually as b8d3758dcd0f2150211ec0f20f28d1246782b4e6 (presubmit successful).
4 years ago (2016-11-30 22:57:57 UTC) #2
Paul Berry
4 years ago (2016-12-01 13:57:54 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698