pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart - Issue 2542753002: Revert "Transition analyzer and analysis_server to new astFactory; remove old AST factory methods."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart

Issue 2542753002: Revert "Transition analyzer and analysis_server to new astFactory; remove old AST factory methods." (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart b/pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart

index adf26c7ab6f3b49a889206add424688f459716e4..f0c2b3a11928a83f495f154e2c8bd84be57bd222 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart

@@ -5,7 +5,6 @@

library services.completion.dart.local.declaration.visitor;

import 'package:analyzer/dart/ast/ast.dart';

-import 'package:analyzer/dart/ast/standard_ast_factory.dart';

import 'package:analyzer/dart/ast/token.dart';

import 'package:analyzer/dart/ast/visitor.dart';

import 'package:analyzer/src/dart/ast/token.dart';

@@ -16,8 +15,8 @@ import 'package:analyzer/src/dart/ast/token.dart';

* which catches the exception thrown by [finished()].

abstract class LocalDeclarationVisitor extends GeneralizingAstVisitor {

- static final TypeName STACKTRACE_TYPE = astFactory.typeName(

- astFactory.simpleIdentifier(

+ static final TypeName STACKTRACE_TYPE = new TypeName(

+ new SimpleIdentifier(

new StringToken(TokenType.IDENTIFIER, 'StackTrace', 0)),

null);