Issue 2542743003: Make QuicClientBase::WaitForCryptoHandshakeComplete return false if the handshake fails. There's cu…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2542743003: Make QuicClientBase::WaitForCryptoHandshakeComplete return false if the handshake fails. There's cu… (Closed)

Created:
4 years ago by Victor Vasiliev

Modified:
4 years ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make QuicClientBase::WaitForCryptoHandshakeComplete return false if the handshake fails. There's currently no verification that the handshake has succeeded when this method returns, resulting in buggy tests. Merge internal change: 139469341 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -39 lines)			Patch
M	net/tools/quic/end_to_end_test.cc	View	37 chunks	+37 lines, -37 lines	0 comments	Download
M	net/tools/quic/quic_client_base.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/tools/quic/quic_client_base.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 2538923003 Patch 1

Dependent Patchsets:

Issue 2543463005 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages