net/tools/quic/quic_client_base.h - Issue 2542743003: Make QuicClientBase::WaitForCryptoHandshakeComplete return false if the handshake fails. There's cu…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_client_base.h

Issue 2542743003: Make QuicClientBase::WaitForCryptoHandshakeComplete return false if the handshake fails. There's cu… (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/tools/quic/quic_client_base.h

diff --git a/net/tools/quic/quic_client_base.h b/net/tools/quic/quic_client_base.h

index ddfaf549ffbc208f8217b615e98cc95fb36d4a3a..66472837f7baa3b46454037a394c7155f1ca25c6 100644

--- a/net/tools/quic/quic_client_base.h

+++ b/net/tools/quic/quic_client_base.h

@@ -133,7 +133,8 @@ class QuicClientBase : public QuicClientPushPromiseIndex::Delegate,

void WaitForStreamToClose(QuicStreamId id);

// Wait for events until the handshake is confirmed.

- void WaitForCryptoHandshakeConfirmed();

+ // Returns true if the crypto handshake succeeds, false otherwise.

+ bool WaitForCryptoHandshakeConfirmed() WARN_UNUSED_RESULT;

// Wait up to 50ms, and handle any events which occur.

// Returns true if there are any outstanding requests.

« no previous file with comments | « net/tools/quic/end_to_end_test.cc ('k') | net/tools/quic/quic_client_base.cc » ('j') | no next file with comments »