Sprinkle some types on the SDK like the static typing fairy.

Sprinkle some types on the SDK like the static typing fairy.

When I'm looking at the dynamic call profiles of an internal app test,
I see a bunch coming from the SDK itself. In fact, the top five most
common dynamic call sites are in the SDK.

This fixes four of them. (The fifth is in runUnary() in Zone, and I
don't think can be made typed yet.)

R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/aa749dbd8d9e1a43c9b43df54802197065ad0080

[Bob Nystrom, 2016-12-01 00:16:11]

rnystrom@google.com changed reviewers:
+ vsm@google.com

[vsm, 2016-12-01 00:21:35]

lgtm!

I think runUnary is generically typed, right?  We getting dcalls regardless?

[Bob Nystrom, 2016-12-01 00:35:56]

On 2016/12/01 00:21:35, vsm wrote:
> lgtm!
> 
> I think runUnary is generically typed, right?  We getting dcalls regardless?

It's not the call to runUnary() itself, but some code inside it that does a
dcall:

      return (zone, f, arg) => {
        let implementation = this[_delegationTarget][_runUnary];
        let implZone = implementation.zone;
        let handler = implementation.function;
        return R.as(dart.dcall(handler, implZone,
async._parentDelegate(implZone), zone, f, arg)); // <--
      };

That's because of:

    RunUnaryHandler handler = implementation.function;
    // TODO(floitsch): make this a generic method call on '<R, T>' once it's
    // supported. Remove the unnecessary cast.
    return handler(implementation.zone, parentDelegate, this, f, arg)
        as Object/*=R*/;

We can't provide type arguments to that RunUnaryHandler because
implementation.function doesn't have them. It doesn't, in turn, I think because
we don't have generic function types. Or maybe just because the zone API is
designed in a way that doesn't play nice with our static type system.

[vsm, 2016-12-01 00:54:01]

On 2016/12/01 00:35:56, Bob Nystrom wrote:
> On 2016/12/01 00:21:35, vsm wrote:
> > lgtm!
> > 
> > I think runUnary is generically typed, right?  We getting dcalls regardless?
> 
> It's not the call to runUnary() itself, but some code inside it that does a
> dcall:
> 
>       return (zone, f, arg) => {
>         let implementation = this[_delegationTarget][_runUnary];
>         let implZone = implementation.zone;
>         let handler = implementation.function;
>         return R.as(dart.dcall(handler, implZone,
> async._parentDelegate(implZone), zone, f, arg)); // <--
>       };
> 
> That's because of:
> 
>     RunUnaryHandler handler = implementation.function;
>     // TODO(floitsch): make this a generic method call on '<R, T>' once it's
>     // supported. Remove the unnecessary cast.
>     return handler(implementation.zone, parentDelegate, this, f, arg)
>         as Object/*=R*/;
> 
> We can't provide type arguments to that RunUnaryHandler because
> implementation.function doesn't have them. It doesn't, in turn, I think
because
> we don't have generic function types. Or maybe just because the zone API is
> designed in a way that doesn't play nice with our static type system.

Thanks - still lgtm

[Bob Nystrom, 2016-12-01 01:04:59]

Description was changed from

==========
Sprinkle some types on the SDK like the static typing fairy.

When I'm looking at the dynamic call profiles of an internal app test,
I see a bunch coming from the SDK itself. In fact, the top five most
common dynamic call sites are in the SDK.

This fixes four of them. (The fifth is in runUnary() in Zone, and I
don't think can be made typed yet.)
==========

to

==========
Sprinkle some types on the SDK like the static typing fairy.

When I'm looking at the dynamic call profiles of an internal app test,
I see a bunch coming from the SDK itself. In fact, the top five most
common dynamic call sites are in the SDK.

This fixes four of them. (The fifth is in runUnary() in Zone, and I
don't think can be made typed yet.)

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/aa749dbd8d9e1a43c9b43df54802197065ad0080
==========

[Bob Nystrom, 2016-12-01 01:05:01]

Committed patchset #1 (id:1) manually as
aa749dbd8d9e1a43c9b43df54802197065ad0080 (presubmit successful).