Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: pkg/dev_compiler/lib/js/amd/dart_sdk.js

Issue 2542723003: Sprinkle some types on the SDK like the static typing fairy. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | pkg/dev_compiler/lib/js/common/dart_sdk.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/js/amd/dart_sdk.js
diff --git a/pkg/dev_compiler/lib/js/amd/dart_sdk.js b/pkg/dev_compiler/lib/js/amd/dart_sdk.js
index eb689c4e939210a4b87ae9220dc05036abb75119..4944bff91a192dcda69097dd4d4b745fc92d7deb 100644
--- a/pkg/dev_compiler/lib/js/amd/dart_sdk.js
+++ b/pkg/dev_compiler/lib/js/amd/dart_sdk.js
@@ -636,7 +636,6 @@ define([], function() {
let dynamic__Todynamic = () => (dynamic__Todynamic = dart.constFn(dart.definiteFunctionType(dart.dynamic, [dart.dynamic], [dart.dynamic])))();
let dynamicTo_Future = () => (dynamicTo_Future = dart.constFn(dart.definiteFunctionType(async._Future, [dart.dynamic])))();
let _AsyncCallbackTovoid = () => (_AsyncCallbackTovoid = dart.constFn(dart.definiteFunctionType(dart.void, [async._AsyncCallback])))();
- let FnTodynamic = () => (FnTodynamic = dart.constFn(dart.definiteFunctionType(dart.dynamic, [VoidTovoid()])))();
let _NotificationHandlerToFuture = () => (_NotificationHandlerToFuture = dart.constFn(dart.definiteFunctionType(async.Future, [async._NotificationHandler])))();
let dynamicAndStackTraceTodynamic = () => (dynamicAndStackTraceTodynamic = dart.constFn(dart.definiteFunctionType(dart.dynamic, [dart.dynamic, core.StackTrace])))();
let dynamic__Tovoid = () => (dynamic__Tovoid = dart.constFn(dart.definiteFunctionType(dart.void, [dart.dynamic], [core.StackTrace])))();
@@ -1169,7 +1168,7 @@ define([], function() {
};
const _wrappedType = Symbol('_wrappedType');
dart.unwrapType = function(obj) {
- return dart.dload(obj, _wrappedType);
+ return obj[_wrappedType];
};
dart._getRuntimeType = function(value) {
return value[dart._runtimeType];
@@ -17259,6 +17258,8 @@ define([], function() {
return end;
};
dart.fn(_native_typed_data._checkValidRange, intAndintAndintToint());
+ async._Callback = dart.typedef('_Callback', () => dart.functionType(dart.void, []));
+ async._TakeCallback = dart.typedef('_TakeCallback', () => dart.functionType(dart.void, [async._Callback]));
async._invokeErrorHandler = function(errorHandler, error, stackTrace) {
if (async.ZoneBinaryCallback.is(errorHandler)) {
return dart.dcall(errorHandler, error, stackTrace);
@@ -17696,7 +17697,7 @@ define([], function() {
dart.assert(!dart.test(this[_inCallback]));
let wasInputPaused = this[_isInputPaused];
this[_state] = (dart.notNull(this[_state]) | async._BufferingStreamSubscription._STATE_IN_CALLBACK) >>> 0;
- dart.dcall(callback);
+ callback();
this[_state] = (dart.notNull(this[_state]) & ~async._BufferingStreamSubscription._STATE_IN_CALLBACK) >>> 0;
this[_checkState](wasInputPaused);
}
@@ -17777,7 +17778,7 @@ define([], function() {
[_sendData]: dart.definiteFunctionType(dart.void, [T]),
[_sendError]: dart.definiteFunctionType(dart.void, [core.Object, core.StackTrace]),
[_sendDone]: dart.definiteFunctionType(dart.void, []),
- [_guardCallback]: dart.definiteFunctionType(dart.void, [dart.dynamic]),
+ [_guardCallback]: dart.definiteFunctionType(dart.void, [VoidTovoid()]),
[_checkState]: dart.definiteFunctionType(dart.void, [core.bool])
}),
sfields: () => ({
@@ -19596,7 +19597,7 @@ define([], function() {
dart.fn(async.scheduleMicrotask, _AsyncCallbackTovoid());
async._AsyncRun = class _AsyncRun extends core.Object {
static _scheduleImmediate(callback) {
- dart.dcall(async._AsyncRun._scheduleImmediateClosure, callback);
+ async._AsyncRun._scheduleImmediateClosure(callback);
}
static _initializeScheduleImmediate() {
if (self.scheduleImmediate != null) {
@@ -19610,7 +19611,7 @@ define([], function() {
_isolate_helper.leaveJsAsync();
let f = storedCallback;
storedCallback = null;
- dart.dcall(f);
+ f();
}
dart.fn(internalCallback, dynamicTodynamic$());
;
@@ -19621,7 +19622,7 @@ define([], function() {
_isolate_helper.enterJsAsync();
storedCallback = callback;
div.firstChild ? div.removeChild(span) : div.appendChild(span);
- }, FnTodynamic());
+ }, _AsyncCallbackTovoid());
} else if (self.setImmediate != null) {
return async._AsyncRun._scheduleImmediateWithSetImmediate;
}
@@ -19652,10 +19653,10 @@ define([], function() {
}
};
dart.setSignature(async._AsyncRun, {
- sfields: () => ({_scheduleImmediateClosure: core.Function}),
+ sfields: () => ({_scheduleImmediateClosure: async._TakeCallback}),
statics: () => ({
_scheduleImmediate: dart.definiteFunctionType(dart.void, [VoidTovoid()]),
- _initializeScheduleImmediate: dart.definiteFunctionType(core.Function, []),
+ _initializeScheduleImmediate: dart.definiteFunctionType(async._TakeCallback, []),
_scheduleImmediateJsOverride: dart.definiteFunctionType(dart.void, [VoidTovoid()]),
_scheduleImmediateWithSetImmediate: dart.definiteFunctionType(dart.void, [VoidTovoid()]),
_scheduleImmediateWithTimer: dart.definiteFunctionType(dart.void, [VoidTovoid()])
@@ -20059,7 +20060,7 @@ define([], function() {
subscription[_setPendingEvents](pendingEvents);
subscription[_guardCallback](dart.fn(() => {
async._runGuarded(this.onListen);
- }, VoidTodynamic$()));
+ }, VoidTovoid$()));
return subscription;
}
[_recordCancel](subscription) {
« no previous file with comments | « no previous file | pkg/dev_compiler/lib/js/common/dart_sdk.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698