Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2542703002: DevTools: Editing of node.js should not add a new line after shebang. (Closed)

Created:
4 years ago by lushnikov
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Editing of node.js should not add a new line after shebang. The shebang prefix is substituted in node without the newline. BUG=none R=dgozman Committed: https://crrev.com/52602dec71bc8853f4dc0b4fb770553bf314ea5b Cr-Commit-Position: refs/heads/master@{#435458}

Patch Set 1 #

Messages

Total messages: 11 (6 generated)
lushnikov
The node trimming of shebang: https://github.com/nodejs/node/blob/0fb21df6e692bef9f55b9bfa876f3c59dc590332/lib/internal/bootstrap_node.js#L130
4 years ago (2016-11-30 21:08:21 UTC) #1
dgozman
lgtm
4 years ago (2016-11-30 21:51:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542703002/1
4 years ago (2016-11-30 22:09:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 22:48:12 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-30 22:50:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52602dec71bc8853f4dc0b4fb770553bf314ea5b
Cr-Commit-Position: refs/heads/master@{#435458}

Powered by Google App Engine
This is Rietveld 408576698