DevTools: [Persistence] sync working copies of UISourceCodes

DevTools: [Persistence] sync working copies of UISourceCodes

Today, persistence reacts only on UISourceCode's "commit" events to
sync content between UISourceCodes.

This patch teaches Persistence to also sync working copies between
UISourceCodes.

This is a prerequisite for showing filesystem file instead of
network uisourcecode.

BUG=649837
R=dgozman

Committed: https://crrev.com/70b1c266df857360b1cbf99d1d0735006c70d775
Cr-Commit-Position: refs/heads/master@{#435862}

[lushnikov, 2016-11-30 02:08:41]

please take a look

[lushnikov, 2016-11-30 02:08:44]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 02:09:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 03:33:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 03:33:32]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lushnikov, 2016-11-30 23:13:03]

i rebaselined the patch; could you please take another look?

[dgozman, 2016-11-30 23:27:39]

On 2016/11/30 23:13:03, lushnikov wrote:
> i rebaselined the patch; could you please take another look?

I'll take a close look tomorrow.

[dgozman, 2016-12-01 21:58:12]

lgtm

https://codereview.chromium.org/2537233003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
(right):

https://codereview.chromium.org/2537233003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:67: if
(binding.network.isDirty())
Let's remove this one?

https://codereview.chromium.org/2537233003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:101:
.then(currentContent => this._rewrapNodeJSContent(binding, other,
currentContent, newContent))
Use workingCopy() instead of currentContent.

https://codereview.chromium.org/2537233003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:114:
other.setWorkingCopyGetter(() => uiSourceCode.workingCopy());
workingCopyGetter

https://codereview.chromium.org/2537233003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:134:
.then(newContent => setContent.call(this, newContent));
Let's not chain sync calls.

[lushnikov, 2016-12-02 02:51:37]

https://codereview.chromium.org/2537233003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
(right):

https://codereview.chromium.org/2537233003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:67: if
(binding.network.isDirty())
On 2016/12/01 21:58:12, dgozman wrote:
> Let's remove this one?

Done.

https://codereview.chromium.org/2537233003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:101:
.then(currentContent => this._rewrapNodeJSContent(binding, other,
currentContent, newContent))
On 2016/12/01 21:58:12, dgozman wrote:
> Use workingCopy() instead of currentContent.

Done.

https://codereview.chromium.org/2537233003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:114:
other.setWorkingCopyGetter(() => uiSourceCode.workingCopy());
On 2016/12/01 21:58:12, dgozman wrote:
> workingCopyGetter

Done.

https://codereview.chromium.org/2537233003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:134:
.then(newContent => setContent.call(this, newContent));
On 2016/12/01 21:58:12, dgozman wrote:
> Let's not chain sync calls.

Done.

[lushnikov, 2016-12-02 02:51:41]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-12-02 02:51:41]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2537233003/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2016-12-02 02:52:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 05:02:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480647101106360,
"parent_rev": "52d23019912d74d94e7a2c3db75a67ae286fcfe1", "commit_rev":
"806e1f1ce095b022e0431e3d6bbe771cb4f3700b"}

[commit-bot: I haz the power, 2016-12-02 05:02:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-02 05:06:48]

Description was changed from

==========
DevTools: [Persistence] sync working copies of UISourceCodes

Today, persistence reacts only on UISourceCode's "commit" events to
sync content between UISourceCodes.

This patch teaches Persistence to also sync working copies between
UISourceCodes.

This is a prerequisite for showing filesystem file instead of
network uisourcecode.

BUG=649837
R=dgozman
==========

to

==========
DevTools: [Persistence] sync working copies of UISourceCodes

Today, persistence reacts only on UISourceCode's "commit" events to
sync content between UISourceCodes.

This patch teaches Persistence to also sync working copies between
UISourceCodes.

This is a prerequisite for showing filesystem file instead of
network uisourcecode.

BUG=649837
R=dgozman

Committed: https://crrev.com/70b1c266df857360b1cbf99d1d0735006c70d775
Cr-Commit-Position: refs/heads/master@{#435862}
==========

[commit-bot: I haz the power, 2016-12-02 05:06:49]

Patchset 3 (id:??) landed as
https://crrev.com/70b1c266df857360b1cbf99d1d0735006c70d775
Cr-Commit-Position: refs/heads/master@{#435862}