Issue 2542683002: [Blink Heap] Move isLowEndDevice to Memory Coordinator, attempt #3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2542683002: [Blink Heap] Move isLowEndDevice to Memory Coordinator, attempt #3 (Closed)

Created:
4 years ago by whywhat

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

[Blink Heap] Move isLowEndDevice to Memory Coordinator, attempt #3 A preparation for https://codereview.chromium.org/2475293003 to be able to override this from tests. Had to go with a static method approach. Seems like hanging it off the heap allocated object breaks blink_heap_unittests on Mac and Windows (see https://codereview.chromium.org/2503433003 and https://codereview.chromium.org/2510353005). BUG=659672 TEST=Run the blink_heap_unittests locally (on Linux). Review-Url: https://codereview.chromium.org/2518273003 Cr-Commit-Position: refs/heads/master@{#434027} (cherry picked from commit caab7202c6ecbbaf5caa71be51e7c1d061606f35)

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -9 lines)			Patch
M	third_party/WebKit/Source/core/fetch/MemoryCache.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/platform/MemoryCoordinator.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/MemoryCoordinator.cpp	View	3 chunks	+7 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/heap/Heap.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/platform/heap/Heap.cpp	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/platform/heap/HeapPage.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 1 (0 generated)

whywhat

4 years ago (2016-11-30 17:23:23 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
4d3ac34c6ec966cd562de4a9fb23ef7582a5a9b6.